Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rustdoc): remove JS code that uses nonexistent GENERICS_DATA #86648

Closed

Conversation

notriddle
Copy link
Contributor

The search index stopped including this data back with b9167e6, which changed the format of function i/o types from [name, generics] to [name, kind] (since TypeWithKind directly serializes the name, and does not serialize the generics data).

The search index stopped including this data back with b9167e6,
which changed the format of function i/o types from `[name, generics]`
to `[name, kind]` (since TypeWithKind directly serializes the name, and
does not serialize the generics data).
@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 26, 2021
@GuillaumeGomez
Copy link
Member

The idea was to look in the specialization of generics. For example, S: Debug + String would match for both Debug and String. So instead of removing it, would it be possible instead of to put back this behaviour and add a test to ensure it's respected instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants