Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for const trait impls behind feature gates #86775

Merged
merged 2 commits into from
Jul 2, 2021

Conversation

fee1-dead
Copy link
Member

@fee1-dead fee1-dead commented Jul 1, 2021

  • Make the previous cross-crate tests use revisions instead of being separate files
  • Added test for gating const trait impls.

cc @oli-obk @jonas-schievink

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 1, 2021
@jonas-schievink
Copy link
Contributor

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 1, 2021

📌 Commit ee9c614 has been approved by jonas-schievink

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jul 1, 2021
…schievink

Test for const trait impls behind feature gates

 - Make the previous cross-crate tests use revisions instead of being separate files
 - Added test for gating const trait impls.

cc `@oli-obk` `@jonas-schievink`
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 1, 2021
Rollup of 7 pull requests

Successful merges:

 - rust-lang#86148 (Check the number of generic lifetime and const parameters of intrinsics)
 - rust-lang#86659 (fix(rustdoc): generics search)
 - rust-lang#86768 (Add myself to mailmap)
 - rust-lang#86775 (Test for const trait impls behind feature gates)
 - rust-lang#86779 (Allow anyone to add or remove any label starting with perf-)
 - rust-lang#86783 (Move Mutex::unlock to T: ?Sized)
 - rust-lang#86785 (proc_macro/bridge: Remove dead code Slice type)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4262598 into rust-lang:master Jul 2, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 2, 2021
@fee1-dead fee1-dead deleted the impl-const-test branch May 12, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants