Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

constified implementations of Default #86808

Merged
merged 2 commits into from
Aug 18, 2021
Merged

constified implementations of Default #86808

merged 2 commits into from
Aug 18, 2021

Commits on Aug 17, 2021

  1. Constified Default implementations 

    The libs-api team agrees to allow const_trait_impl to appear in the
standard library as long as stable code cannot be broken (they are
properly gated) this means if the compiler teams thinks it's okay, then
it's okay.

My priority on constifying would be:

	1. Non-generic impls (e.g. Default) or generic impls with no
	   bounds
	2. Generic functions with bounds (that use const impls)
	3. Generic impls with bounds
	4. Impls for traits with associated types

For people opening constification PRs: please cc me and/or oli-obk.
    @fee1-dead
    fee1-dead committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    b5afa68 View commit details
    Browse the repository at this point in the history

  2. Add ui test

    @fee1-dead
    fee1-dead committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    6bd2ecb View commit details
    Browse the repository at this point in the history