-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fast path for Path::cmp that skips over long shared prefixes #86898
Conversation
the8472
commented
Jul 5, 2021
r? @dtolnay (rust-highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Mostly looks good -- one comment where more inline isn't necessarily better.
@bors r+ |
📌 Commit dfdf361 has been approved by |
@bors rollup=never (perf implication seems unlikely, but good to not hit in a roll-up). |
☀️ Test successful - checks-actions |
This seems to have been a small regression on a number of -doc benchmarks that seems unlikely to be limited to just noise. It might be worth trying to identify what pattern rustdoc is using in path comparisons that leads to this being slower. @rustbot label perf-regression |
Regarding regression, it looks like The init argument to |
It often makes sense for iterators where the caller of the closure will also be |
…e, r=Mark-Simulacrum Don't inline OnceCell initialization closures The more general variant of rust-lang#89026, originally suggested in rust-lang#86898 (comment)