Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type: 'satic -> 'static #87028

Merged
merged 1 commit into from
Jul 10, 2021
Merged

Fix type: 'satic -> 'static #87028

merged 1 commit into from
Jul 10, 2021

Conversation

aDotInTheVoid
Copy link
Member

@aDotInTheVoid aDotInTheVoid commented Jul 10, 2021 •
edited
Loading

Pointed out on discord: https://discord.com/channels/273534239310479360/490356824420122645/863434443170250793

The fact that this compiles is probably a bug. Nope it's #![feature(in_band_lifetimes)] (Thanks to floppy

The docs seem to indicate rust thinks this function is generic over the lifetime 'satic This is because of in_band_lifetimes

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 10, 2021
@aDotInTheVoid
Copy link
Member Author

And of corse I had to typo the commit message 😅

@petrochenkov
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 10, 2021

📌 Commit 293fa8f has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2021
@JohnTitor JohnTitor mentioned this pull request Jul 10, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 10, 2021
@bors
Auto merge of rust-lang#87029 - JohnTitor:rollup-0yapv7z, r=JohnTitor
a31431f 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#87006 (Revert the revert of renaming traits::VTable to ImplSource)
 - rust-lang#87011 (avoid reentrant lock acquire when ThreadIds run out)
 - rust-lang#87013 (Fix several ICEs related to malformed `#[repr(...)]` attributes)
 - rust-lang#87020 (remove const_raw_ptr_to_usize_cast feature)
 - rust-lang#87028 (Fix type: `'satic` -> `'static`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 36b142f into rust-lang:master Jul 10, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.
5 participants
@aDotInTheVoid @rust-highfive @petrochenkov @bors @rustbot