Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liberate before normalizing in wfcheck #87113

Closed
wants to merge 2 commits into from

Conversation

jackh726
Copy link
Member

Split from #85499 and #86993

Hopefully this is the perf regression in those. This is a correctness fix (though it doesn't do anything without those changes).

r? @nikomatsakis

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 13, 2021
@jackh726
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 13, 2021
@bors
Copy link
Contributor

bors commented Jul 13, 2021

⌛ Trying commit 166d602 with merge efd671be08a7ed6025e86da94a4224436d0c218c...

@jackh726
Copy link
Member Author

Oh interesting, looks like this changes test output

@jackh726
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Jul 13, 2021

⌛ Trying commit 26e4fa5 with merge 437a1916f2bddb8794de1b3ef98fdab9ee814118...

@bors
Copy link
Contributor

bors commented Jul 13, 2021

☀️ Try build successful - checks-actions
Build commit: 437a1916f2bddb8794de1b3ef98fdab9ee814118 (437a1916f2bddb8794de1b3ef98fdab9ee814118)

@rust-timer
Copy link
Collaborator

Queued 437a1916f2bddb8794de1b3ef98fdab9ee814118 with parent 3e1c75c, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (437a1916f2bddb8794de1b3ef98fdab9ee814118): comparison url.

Summary: This benchmark run did not return any significant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 14, 2021
@jackh726
Copy link
Member Author

These were included in #86993

@jackh726 jackh726 closed this Jul 16, 2021
@jackh726 jackh726 deleted the wfcheck-normalize branch July 16, 2021 04:07
@jackh726 jackh726 restored the wfcheck-normalize branch March 12, 2022 18:30
@jackh726 jackh726 deleted the wfcheck-normalize branch March 12, 2022 18:38
@jackh726 jackh726 restored the wfcheck-normalize branch March 12, 2022 18:42
@jackh726 jackh726 deleted the wfcheck-normalize branch March 12, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants