Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document private items for rustfmt #87119

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Document private items for rustfmt #87119

merged 1 commit into from
Aug 17, 2021

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Jul 14, 2021

This is possible now that #73936 has been merged.

@jyn514 jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-rustfmt Area: Rustfmt A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself labels Jul 14, 2021
@rust-highfive
Copy link
Collaborator

Some changes occurred in src/tools/rustfmt.

cc @calebcartwright

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 14, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2021
@Mark-Simulacrum
Copy link
Member

Since we'll be bootstrapping from 1.55 shortly (once #87622) merges, let's drop the cfg(not(bootstrap)) here?

r=me once that's done and #87622 is merged.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2021
@jyn514 jyn514 force-pushed the rustfmt-doc-private branch from 859537b to 8561b68 Compare August 16, 2021 01:46
@jyn514
Document private items for rustfmt
6216b4e 
This is possible now that rustdoc allows passing
`--document-private-items` more than once.
@jyn514 jyn514 force-pushed the rustfmt-doc-private branch from 8561b68 to 6216b4e Compare August 16, 2021 01:47
@jyn514
Copy link
Member Author

jyn514 commented Aug 16, 2021

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Aug 16, 2021

📌 Commit 6216b4e has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 16, 2021
@jyn514 jyn514 changed the title Document private items for rustfmt when documenting with stage1 or above Document private items for rustfmt Aug 16, 2021
@bors
Copy link
Contributor

bors commented Aug 17, 2021

⌛ Testing commit 6216b4e with merge 3b5df01...

@bors
Copy link
Contributor

bors commented Aug 17, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 3b5df01 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 17, 2021
@bors bors merged commit 3b5df01 into rust-lang:master Aug 17, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 17, 2021
@jyn514 jyn514 deleted the rustfmt-doc-private branch August 17, 2021 08:17
calebcartwright pushed a commit to calebcartwright/rust that referenced this pull request Oct 20, 2021
@bors
Auto merge of rust-lang#87119 - jyn514:rustfmt-doc-private, r=Mark-Si…
e1dac88 
…mulacrum

Document private items for rustfmt

This is possible now that rust-lang#73936 has been merged.
@calebcartwright calebcartwright mentioned this pull request Oct 22, 2021
Closed
ytmimi added a commit to ytmimi/rustfmt that referenced this pull request Oct 23, 2021
@ytmimi
Add rustdoc CI check
af9c94a 
Resolves 5038

rust-lang/rust builds now document rustfmt (rust-lang/rust#87119). The
build process is updated with doc checks to ensure that rustfmt doesn't
introduce warnings.

Warnings are treated as hard errors in rust-lang/rust and won't show
until bors tests the changes (refs rust-lang/rust#90087).
@ytmimi ytmimi mentioned this pull request Oct 23, 2021
Merged
ytmimi added a commit to ytmimi/rustfmt that referenced this pull request Oct 25, 2021
@ytmimi
Add rustdoc CI check
d205ffb 
Resolves 5038

rust-lang/rust builds now document rustfmt (rust-lang/rust#87119). The
build process is updated with doc checks to ensure that rustfmt doesn't
introduce warnings.

Warnings are treated as hard errors in rust-lang/rust and won't show
until bors tests the changes (refs rust-lang/rust#90087).
calebcartwright pushed a commit to rust-lang/rustfmt that referenced this pull request Oct 26, 2021
@ytmimi @calebcartwright
Add rustdoc CI check
d454e81 
Resolves 5038

rust-lang/rust builds now document rustfmt (rust-lang/rust#87119). The
build process is updated with doc checks to ensure that rustfmt doesn't
introduce warnings.

Warnings are treated as hard errors in rust-lang/rust and won't show
until bors tests the changes (refs rust-lang/rust#90087).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-rustfmt Area: Rustfmt merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jyn514 @rust-highfive @Mark-Simulacrum @bors @JohnCSimon @rustbot