Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misuse of rev attribute on <a> tag #87154

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Fix misuse of rev attribute on <a> tag #87154

merged 1 commit into from
Jul 15, 2021

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jul 15, 2021 •
edited
Loading

The rev attribute is supposed to talk about "ownership" as far as I could found out. This attribute seems not very well defined in the HTML spec and its usage in rustdoc is suboptimal.

It was found out in #87149.

r? @JohnTitor

@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jul 15, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 15, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
Copy link
Member Author

And of course I forgot to format as usual... 😢

@JohnTitor
Copy link
Member

I'm not part of the rustdoc team but this fix seems quite straightforward. But I haven't understood why my rollup triggers it (i.e. previous build didn't trigger it). Could you elaborate? Should we recreate the rollup?

@GuillaumeGomez
Copy link
Member Author

I'm honestly not sure either. Something might have been added into the index that wasn't there before, triggering the generation of this link which then fails the HTML check (which has been added a few weeks ago). I didn't look into details but I expect something like this. Well at least it allowed us to spot this issue.

@JohnTitor
Copy link
Member

Hmm, okay, let's r+ anyway. I assume it's flaky and I'll recreate a rollup if the running one fails. Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Jul 15, 2021

📌 Commit 9bab94f has been approved by JohnTitor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2021
@JohnTitor JohnTitor mentioned this pull request Jul 15, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 15, 2021
@bors
Auto merge of rust-lang#87156 - JohnTitor:rollup-osuhe53, r=JohnTitor
0a6c636 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#85579 (Added Arc::try_pin)
 - rust-lang#86478 (Add -Zfuture-incompat-test to assist with testing future-incompat reports.)
 - rust-lang#86947 (Move assert_matches to an inner module)
 - rust-lang#87081 (Add tracking issue number to `wasi_ext`)
 - rust-lang#87127 (Add safety comments in private core::slice::rotate::ptr_rotate function)
 - rust-lang#87134 (Make SelfInTyParamDefault wording not be specific to type defaults)
 - rust-lang#87147 (Update cargo)
 - rust-lang#87154 (Fix misuse of rev attribute on <a> tag)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@the8472
Copy link
Member

the8472 commented Jul 15, 2021

This attribute seems not very well defined in the HTML spec and its usage in rustdoc is suboptimal.

It's listed in the HTML4.01 spec
But not in the HTML5 spec
MDN lists it as deprecated

@bors bors merged commit 262a4f9 into rust-lang:master Jul 15, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 15, 2021
@GuillaumeGomez GuillaumeGomez deleted the rev-attr-a branch July 15, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.
7 participants
@GuillaumeGomez @rust-log-analyzer @JohnTitor @bors @the8472 @rust-highfive @rustbot