Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't abort compilation after giving a lint error #87337

Merged
merged 3 commits into from
Nov 9, 2021
Merged

Don't abort compilation after giving a lint error #87337

merged 3 commits into from
Nov 9, 2021

Commits on Nov 8, 2021

  1. Don't abort compilation after giving a lint error 

    The only reason to use `abort_if_errors` is when the program is so broken that either:
1. later passes get confused and ICE
2. any diagnostics from later passes would be noise

This is never the case for lints, because the compiler has to be able to deal with `allow`-ed lints.
So it can continue to lint and compile even if there are lint errors.
    @jyn514
    jyn514 committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    0ac13bd View commit details
    Browse the repository at this point in the history

  2. Don't proceed to codegen if there are lint errors

    @jyn514
    jyn514 committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    c008bb0 View commit details
    Browse the repository at this point in the history

  3. Use has_errors_or_lint_errors in rustdoc instead of `abort_if_error… 

    …s()`

Rustdoc is special as usual and doesn't go through RunCompiler, so it
needs its own explicit checks. The rest of the tools go through
RunCompiler, so they should be fine.
    @jyn514
    jyn514 committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    ebf8966 View commit details
    Browse the repository at this point in the history