Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VxWork's UNIX support #87354

Merged
merged 2 commits into from
Jul 27, 2021
Merged

Update VxWork's UNIX support #87354

merged 2 commits into from
Jul 27, 2021

Conversation

NicholasBaron
Copy link
Contributor

  1. VxWorks does not provide glibc
  2. VxWorks does provide sigemptyset and sigaddset

Note: these changes are concurrent to this PR in libc.

VxWorks does not provide glibc, but we still need to test rustc on
VxWorks.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kennytm (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 21, 2021
@NicholasBaron
Copy link
Contributor Author

@kennytm The libc changes were merged, so I think this should be ready for review.

@kennytm
Copy link
Member

kennytm commented Jul 27, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 27, 2021

📌 Commit 7a9dd00 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 27, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 27, 2021
Rollup of 10 pull requests

Successful merges:

 - rust-lang#86450 (Add flag to configure `large_assignments` lint)
 - rust-lang#86764 (Avoid ICE on type error recovery)
 - rust-lang#87354 (Update VxWork's UNIX support)
 - rust-lang#87427 (get rid of NoMirFor error variant)
 - rust-lang#87446 (macos current_exe using directly libc instead.)
 - rust-lang#87494 (fix typo: whenver -> whenever)
 - rust-lang#87497 (Add long explanation for E0544.)
 - rust-lang#87499 (Remove ASCII fast path from `rustc_lexer::{is_id_continue, is_id_start}`)
 - rust-lang#87502 (Update cargo)
 - rust-lang#87503 (Update books)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@NicholasBaron
Copy link
Contributor Author

The CI error is related to a submodule not having a particular commit. However, I did not edit the .gitmodules file, so I do not see how the error is related to my changes.

@bors bors merged commit 90f6d7b into rust-lang:master Jul 27, 2021
@rustbot rustbot added this to the 1.56.0 milestone Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants