Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct users towards using Rust target feature names in CLI #87402

Merged

Commits on Feb 27, 2022

  1. Do not pass through features without +/- prefix

    LLVM really dislikes this and will assert, saying something along the
    lines of:
    
    ```
    rustc: llvm/lib/MC/MCSubtargetInfo.cpp:60: void ApplyFeatureFlag(
      llvm::FeatureBitset&, llvm::StringRef, llvm::ArrayRef<llvm::SubtargetFeatureKV>
    ): Assertion
      `SubtargetFeatures::hasFlag(Feature) && "Feature flags should start with '+' or '-'"`
    failed.
    ```
    nagisa committed Feb 27, 2022
    Configuration menu
    Copy the full SHA
    dfcfaa4 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2022

  1. Direct users towards using Rust feature names in CLI

    If they are trying to use features rustc doesn't yet know about,
    request a feature request.
    
    Additionally, also warn against using feature names without leading `+`
    or `-` signs.
    nagisa committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    c97c216 View commit details
    Browse the repository at this point in the history
  2. Querify global_backend_features

    At the very least this serves to deduplicate the diagnostics that are
    output about unknown target features provided via CLI.
    nagisa committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    df701a2 View commit details
    Browse the repository at this point in the history