Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename const checking visitor module to check_consts::check #87424

Merged
merged 2 commits into from
Jul 26, 2021
Merged

rename const checking visitor module to check_consts::check #87424

merged 2 commits into from
Jul 26, 2021

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Jul 24, 2021 •
edited
Loading

This avoids naming ambiguities with "const validation" which is in interpret/validity.rs and checks values.

r? @oli-obk

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 24, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Jul 25, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 25, 2021

📌 Commit 83bc657 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2021
@bors
Copy link
Contributor

bors commented Jul 26, 2021

⌛ Testing commit 83bc657 with merge 3bcce82...

@bors
Copy link
Contributor

bors commented Jul 26, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 3bcce82 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 26, 2021
@bors bors merged commit 3bcce82 into rust-lang:master Jul 26, 2021
@rustbot rustbot added this to the 1.56.0 milestone Jul 26, 2021
This was referenced Jul 26, 2021
Closed
Merged
@RalfJung RalfJung deleted the const-check branch July 28, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.
5 participants
@RalfJung @oli-obk @bors @rust-highfive @rustbot