-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent spelling of "adapter" in the standard library #87629
Conversation
Change all occurrences of "(A|a)daptor" to "(A|a)dapter".
@rust-highfive failed. I’m choosing at random from this list. r? @kennytm |
@bors r+ rollup |
📌 Commit 8d2bb93 has been approved by |
⌛ Testing commit 8d2bb93 with merge eaab0ccc385a561c017f51382a76efe85544d759... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
Failed building LLVM, seems unrelated to this PR. |
Ah, there’s an “error: Connection to server timed out” in the logs, so a spurious failure. |
@bors retry |
Rollup of 13 pull requests Successful merges: - rust-lang#86183 (Change environment variable getters to error recoverably) - rust-lang#86439 (Remove `Ipv4Addr::is_ietf_protocol_assignment`) - rust-lang#86509 (Move `os_str_bytes` to `sys::unix`) - rust-lang#86593 (Partially stabilize `const_slice_first_last`) - rust-lang#86936 (Add documentation for `Ipv6MulticastScope`) - rust-lang#87282 (Ensure `./x.py dist` adheres to `build.tools`) - rust-lang#87468 (Update rustfmt) - rust-lang#87504 (Update mdbook.) - rust-lang#87608 (Remove unused field `Session.system_library_path`) - rust-lang#87629 (Consistent spelling of "adapter" in the standard library) - rust-lang#87633 (Update compiler_builtins to fix i128 shift/mul on thumbv6m) - rust-lang#87644 (Recommend `swap_remove` in `Vec::remove` docs) - rust-lang#87653 (mark a UB doctest as no_run) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This matches what Rust docs use (since rust-lang/rust#87629). Fixes #3824
Change all occurrences of "(A|a)daptor" to "(A|a)dapter".
The spelling “adapter” seems to be significantly more common both in general in the English language and also in the
rust
repository and standard library. I don’t like the inconsistency that’s currently found on pages like https://doc.rust-lang.org/std/iter/trait.Iterator.html. Note however that the Rust book consistently uses the spelling “iterator adaptor”.Related discussion on Zulip (in the archive).
@rustbot label T-libs