-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Greatly improve limitation handling on parallel rustdoc GUI test run #88188
Merged
bors
merged 1 commit into
rust-lang:master
from
GuillaumeGomez:rustdoc-gui-parallel-limit
Aug 23, 2021
Merged
Greatly improve limitation handling on parallel rustdoc GUI test run #88188
bors
merged 1 commit into
rust-lang:master
from
GuillaumeGomez:rustdoc-gui-parallel-limit
Aug 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
the
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
label
Aug 20, 2021
the8472
reviewed
Aug 20, 2021
GuillaumeGomez
force-pushed
the
rustdoc-gui-parallel-limit
branch
from
August 21, 2021 16:07
ae9dc54
to
839ea2d
Compare
@the8472 I implemented your suggestion, thanks a lot! I discovered |
dns2utf8
suggested changes
Aug 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, I have some minor change requests
GuillaumeGomez
force-pushed
the
rustdoc-gui-parallel-limit
branch
from
August 23, 2021 12:26
839ea2d
to
b7fe005
Compare
@bors: r=dns2utf8 rollup |
📌 Commit b7fe005 has been approved by |
bors
added
the
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Aug 23, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 23, 2021
Rollup of 6 pull requests Successful merges: - rust-lang#87976 (Account for tabs when highlighting multiline code suggestions) - rust-lang#88174 (Clarify some wording in Rust 2021 lint docs) - rust-lang#88188 (Greatly improve limitation handling on parallel rustdoc GUI test run) - rust-lang#88230 (Fix typos “a”→“an”) - rust-lang#88232 (Add notes to macro-not-found diagnostics to point out how things with the same name were not a match.) - rust-lang#88259 (Do not mark `-Z thir-unsafeck` as unsound anymore) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #88082.
r? @dns2utf8