Add TcpListener::into_incoming and IntoIncoming #88339

piegamesde · 2021-08-25T18:26:38Z

The incoming method is really useful, however for some use cases the borrow
this introduces is needlessly restricting. Thus, an owned variant is added.

r? @joshtriplett

rust-highfive · 2021-08-25T18:26:41Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

joshtriplett · 2021-08-25T21:52:14Z

Seems reasonable to me. This needs to be marked as unstable, though, with a tracking issue added. Once that's done and CI passes, r=me.

piegamesde · 2021-08-26T12:15:00Z

How should I name the feature? tcplistener_into_incoming?

joshtriplett · 2021-08-26T15:58:38Z

That sounds good to me.

The `incoming` method is really useful, however for some use cases the borrow this introduces is needlessly restricting. Thus, an owned variant is added.

joshtriplett · 2021-08-28T06:09:39Z

@bors r+

bors · 2021-08-28T06:09:40Z

📌 Commit ced597e has been approved by joshtriplett

bors · 2021-08-30T01:46:22Z

⌛ Testing commit ced597e with merge d84c304805116ba715faa71e9992e3d3682494ac...

rust-log-analyzer · 2021-08-30T02:35:29Z

The job i686-mingw-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:

---- [rustdoc] rustdoc\macro-document-private-duplicate.rs stdout ----

error: htmldocck failed!
status: exit code: 1
command: "C:\\hostedtoolcache\\windows\\Python\\3.9.6\\x64\\python3.exe" "D:\\a\\rust\\rust\\src/etc/htmldocck.py" "D:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\test\\rustdoc\\macro-document-private-duplicate" "D:\\a\\rust\\rust\\src/test\\rustdoc\\macro-document-private-duplicate.rs"
Some tests failed in compiletest suite=rustdoc mode=rustdoc host=i686-pc-windows-gnu target=i686-pc-windows-gnu
------------------------------------------

------------------------------------------
------------------------------------------
stderr:
------------------------------------------
12: @has check failed
 `PATTERN` did not match
 // @has macro_document_private_duplicate/macro.a_macro.html 'Doc 1.'
19: @!has check failed
 `PATTERN` did not match
 // @!has macro_document_private_duplicate/macro.a_macro.html 'Doc 2.'
Encountered 2 errors

------------------------------------------

---
test result: FAILED. 457 passed; 1 failed; 6 ignored; 0 measured; 0 filtered out; finished in 78.77s



command did not execute successfully: "D:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage0-tools-bin\\compiletest.exe" "--compile-lib-path" "D:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage2\\bin" "--run-lib-path" "D:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage2\\lib\\rustlib\\i686-pc-windows-gnu\\lib" "--rustc-path" "D:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage2\\bin\\rustc.exe" "--rustdoc-path" "D:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\stage2\\bin\\rustdoc.exe" "--src-base" "D:\\a\\rust\\rust\\src/test\\rustdoc" "--build-base" "D:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\test\\rustdoc" "--stage-id" "stage2-i686-pc-windows-gnu" "--suite" "rustdoc" "--mode" "rustdoc" "--target" "i686-pc-windows-gnu" "--host" "i686-pc-windows-gnu" "--llvm-filecheck" "D:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\llvm\\build\\bin\\FileCheck.exe" "--nodejs" "C:\\Program Files\\nodejs\\node" "--npm" "C:\\Program Files\\nodejs\\npm" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0  -Lnative=D:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\native\\rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0  -Lnative=D:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\native\\rust-test-helpers" "--docck-python" "C:\\hostedtoolcache\\windows\\Python\\3.9.6\\x64\\python3.exe" "--lldb-python" "C:\\hostedtoolcache\\windows\\Python\\3.9.6\\x64\\python3.exe" "--gdb" "D:\\a\\rust\\rust\\mingw32\\bin\\gdb" "--llvm-version" "13.0.0-rust-1.56.0-nightly" "--llvm-components" "aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo cfguard codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfogsym debuginfomsf debuginfopdb demangle dlltooldriver dwarflinker dwp engine executionengine extensions filecheck frontendopenacc frontendopenmp fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interfacestub interpreter ipo irreader jitlink libdriver lineeditor linker lto mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit orcshared orctargetprocess passes powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target textapi transformutils vectorize webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo webassemblyutils windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info xray" "--cc" "" "--cxx" "" "--cflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--channel" "nightly" "--color" "always"


Build completed unsuccessfully in 0:43:39
Build completed unsuccessfully in 0:43:39
make: *** [Makefile:80: ci-mingw-subset-1] Error 1

bors · 2021-08-30T02:36:04Z

💔 Test failed - checks-actions

piegamesde · 2021-08-30T12:31:44Z

I don't really understand the error message :(

bors · 2021-09-15T02:49:50Z

⌛ Testing commit ced597e with merge 3ccc225e2a438726b9e5bdcbe4fa239160a86376...

bors · 2021-09-15T03:50:58Z

💔 Test failed - checks-actions

rust-log-analyzer · 2021-09-15T03:51:28Z

The job x86_64-msvc-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[TIMING] Rustc { target: TargetSelection { triple: "x86_64-pc-windows-msvc", file: None }, compiler: Compiler { stage: 1, host: TargetSelection { triple: "x86_64-pc-windows-msvc", file: None } } } -- 0.968
Assembling stage2 compiler (x86_64-pc-windows-msvc)
[TIMING] Sysroot { compiler: Compiler { stage: 2, host: TargetSelection { triple: "x86_64-pc-windows-msvc", file: None } } } -- 0.000
[TIMING] Libdir { compiler: Compiler { stage: 2, host: TargetSelection { triple: "x86_64-pc-windows-msvc", file: None } }, target: TargetSelection { triple: "x86_64-pc-windows-msvc", file: None } } -- 0.000
thread 'main' panicked at 'failed to copy `D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-rustc\x86_64-pc-windows-msvc\release\rustc-main.exe` to `D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2\bin\rustc.exe`: The process cannot access the file because it is being used by another process. (os error 32)', src\bootstrap\lib.rs:1335:17
Build completed unsuccessfully in 0:00:04

piegamesde · 2021-09-15T08:47:55Z

@joshtriplett Can you please help me out on the CI failure? I don't fully understand the logs, but it doesn't look like my commit is causing this

ehuss · 2021-09-15T12:18:46Z

@bors retry

#88924

Add TcpListener::into_incoming and IntoIncoming The `incoming` method is really useful, however for some use cases the borrow this introduces is needlessly restricting. Thus, an owned variant is added. r? `@joshtriplett`

Rollup of 10 pull requests Successful merges: - rust-lang#86382 (Make diagnostics clearer for `?` operators) - rust-lang#87529 (Fix ICE in `improper_ctypes_definitions` lint with all-ZST transparent types) - rust-lang#88339 (Add TcpListener::into_incoming and IntoIncoming) - rust-lang#88735 (Don't lint about missing code examples in derived traits) - rust-lang#88751 (Couple of changes to FileSearch and SearchPath) - rust-lang#88883 (Move some tests to more reasonable directories - 7) - rust-lang#88887 (Const Deref) - rust-lang#88911 (Improve error message for type mismatch in generator arguments) - rust-lang#89014 (PassWrapper: handle separate Module*SanitizerPass) - rust-lang#89033 (Set the library path in sysroot-crates-are-unstable) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

Export `tcp::IntoIncoming` Added in rust-lang#88339 but not publicly exported.

m-ou-se · 2022-06-22T17:36:13Z

library/std/src/net/tcp.rs

+    ///     Ok(())
+    /// }
+    /// ```
+    #[unstable(feature = "tcplistener_into_incoming", issue = "88339")]


The tracking issue number here refers to this PR itself. Did something go wrong? Is there an actual tracking issue for this feature?

The tracking issue is #88373, so this likely was a mistake

…coming_issue_number, r=workingjubilee Fix issue number for the `tcplistener_into_incoming` feature As per [this comment](rust-lang#88339 (comment)), the issue number for the `tcplistener_into_incoming` feature is the one of the PR that implements it instead of the tracking issue. - rust-lang#88339 - rust-lang#88373

Rollup merge of rust-lang#126783 - tguichaoua:fix_tcplistener_into_incoming_issue_number, r=workingjubilee Fix issue number for the `tcplistener_into_incoming` feature As per [this comment](rust-lang#88339 (comment)), the issue number for the `tcplistener_into_incoming` feature is the one of the PR that implements it instead of the tracking issue. - rust-lang#88339 - rust-lang#88373

rust-highfive assigned Mark-Simulacrum Aug 25, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 25, 2021

This comment has been minimized.

Sign in to view

Add TcpListener::into_incoming and IntoIncoming

ced597e

The `incoming` method is really useful, however for some use cases the borrow this introduces is needlessly restricting. Thus, an owned variant is added.

piegamesde force-pushed the master branch from 434d6c6 to ced597e Compare August 26, 2021 21:42

piegamesde mentioned this pull request Aug 26, 2021

Tracking Issue for tcplistener_into_incoming #88373

Open

3 tasks

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 30, 2021

Mark-Simulacrum assigned joshtriplett and unassigned Mark-Simulacrum Sep 1, 2021

the8472 added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Sep 8, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2021

GuillaumeGomez mentioned this pull request Sep 16, 2021

Rollup of 13 pull requests #89005

Closed

JohnTitor mentioned this pull request Sep 17, 2021

Rollup of 10 pull requests #89037

Merged

bors merged commit 0f06e36 into rust-lang:master Sep 17, 2021

rustbot added this to the 1.57.0 milestone Sep 17, 2021

petrochenkov mentioned this pull request Sep 24, 2021

Test src\test\rustdoc\macro-document-private-duplicate.rs fails spuriously #89228

Open

ibraheemdev mentioned this pull request Jan 9, 2022

Export tcp::IntoIncoming #92684

Merged

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 14, 2022

Rollup merge of rust-lang#92684 - ibraheemdev:patch-10, r=m-ou-se

4241394

Export `tcp::IntoIncoming` Added in rust-lang#88339 but not publicly exported.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 14, 2022

Rollup merge of rust-lang#92684 - ibraheemdev:patch-10, r=m-ou-se

a5c24bb

Export `tcp::IntoIncoming` Added in rust-lang#88339 but not publicly exported.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 15, 2022

Rollup merge of rust-lang#92684 - ibraheemdev:patch-10, r=m-ou-se

d7e512c

Export `tcp::IntoIncoming` Added in rust-lang#88339 but not publicly exported.

m-ou-se reviewed Jun 22, 2022

View reviewed changes

tguichaoua mentioned this pull request Jun 21, 2024

Fix issue number for the tcplistener_into_incoming feature #126783

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add TcpListener::into_incoming and IntoIncoming #88339

Add TcpListener::into_incoming and IntoIncoming #88339

piegamesde commented Aug 25, 2021 •

edited

Loading

rust-highfive commented Aug 25, 2021

This comment has been minimized.

joshtriplett commented Aug 25, 2021

piegamesde commented Aug 26, 2021

joshtriplett commented Aug 26, 2021

joshtriplett commented Aug 28, 2021

bors commented Aug 28, 2021

bors commented Aug 30, 2021

rust-log-analyzer commented Aug 30, 2021

bors commented Aug 30, 2021

piegamesde commented Aug 30, 2021

bors commented Sep 15, 2021

bors commented Sep 15, 2021

rust-log-analyzer commented Sep 15, 2021

piegamesde commented Sep 15, 2021

ehuss commented Sep 15, 2021

m-ou-se Jun 22, 2022

piegamesde Jul 17, 2022

Add TcpListener::into_incoming and IntoIncoming #88339

Add TcpListener::into_incoming and IntoIncoming #88339

Conversation

piegamesde commented Aug 25, 2021 • edited Loading

rust-highfive commented Aug 25, 2021

This comment has been minimized.

joshtriplett commented Aug 25, 2021

piegamesde commented Aug 26, 2021

joshtriplett commented Aug 26, 2021

joshtriplett commented Aug 28, 2021

bors commented Aug 28, 2021

bors commented Aug 30, 2021

rust-log-analyzer commented Aug 30, 2021

bors commented Aug 30, 2021

piegamesde commented Aug 30, 2021

bors commented Sep 15, 2021

bors commented Sep 15, 2021

rust-log-analyzer commented Sep 15, 2021

piegamesde commented Sep 15, 2021

ehuss commented Sep 15, 2021

m-ou-se Jun 22, 2022

Choose a reason for hiding this comment

piegamesde Jul 17, 2022

Choose a reason for hiding this comment

piegamesde commented Aug 25, 2021 •

edited

Loading