Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for clobbering xer, cr, and cr[0-7] for asm! on OpenPower/PowerPC #88350

Merged
merged 1 commit into from
Sep 1, 2021
Merged

add support for clobbering xer, cr, and cr[0-7] for asm! on OpenPower/PowerPC #88350

merged 1 commit into from
Sep 1, 2021

Conversation

programmerjake
Copy link
Member

Fixes #88315

@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 26, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@programmerjake
Copy link
Member Author

@rustbot label: O-PowerPC A-inline-assembly

@rustbot rustbot added A-inline-assembly Area: inline asm!(..) O-PowerPC Target: PowerPC processors labels Aug 30, 2021
@programmerjake
Copy link
Member Author

@Amanieu mentioned that it should be fine to have xer and cr* as clobbers rather than adding to preserves_flags:
https://rust-lang.zulipchat.com/#narrow/stream/216763-project-inline-asm/topic/preserve_flags.20on.20OpenPower.2FPowerPC.3F/near/251292056

@Amanieu
Copy link
Member

Amanieu commented Aug 30, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Aug 30, 2021

📌 Commit 5802f60 has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2021
@programmerjake
Copy link
Member Author

thanks!

@m-ou-se m-ou-se mentioned this pull request Sep 1, 2021
Merged
@davidtwco davidtwco assigned Amanieu and unassigned davidtwco Sep 1, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 1, 2021
@bors
Auto merge of rust-lang#88556 - m-ou-se:rollup-q636wyd, r=m-ou-se
3ed6c1d 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#86376 (Emit specific warning to clarify that `#[no_mangle]` should not be applied on foreign statics or functions)
 - rust-lang#88040 (BTree: remove Ord bound from new)
 - rust-lang#88053 (Fix the flock fallback implementation)
 - rust-lang#88350 (add support for clobbering xer, cr, and cr[0-7] for asm! on OpenPower/PowerPC)
 - rust-lang#88410 (Remove bolding on associated constants)
 - rust-lang#88525 (fix(rustc_typeck): produce better errors for dyn auto trait)
 - rust-lang#88542 (Use the return value of readdir_r() instead of errno)
 - rust-lang#88548 (Stabilize `Iterator::intersperse()`)
 - rust-lang#88551 (Stabilize `UnsafeCell::raw_get()`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 494c563 into rust-lang:master Sep 1, 2021
@rustbot rustbot added this to the 1.56.0 milestone Sep 1, 2021
@programmerjake programmerjake deleted the add-ppc-cr-xer-clobbers branch September 1, 2021 16:34
@infinity0 infinity0 mentioned this pull request Oct 10, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
A-inline-assembly Area: inline asm!(..) O-PowerPC Target: PowerPC processors S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.

PowerPC64 inline assembly doesn't support clobbering xer and cr
7 participants
@programmerjake @rust-highfive @rust-log-analyzer @Amanieu @bors @davidtwco @rustbot