Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix drop handling for if let expressions #88572

Merged
merged 4 commits into from
Sep 3, 2021
Merged

Fix drop handling for if let expressions #88572

merged 4 commits into from
Sep 3, 2021

Commits on Sep 1, 2021

  1. Fix drop handling for if let expressions 

    MIR lowering for `if let` expressions is now more complicated now that
`if let` exists in HIR. This PR adds a scope for the variables bound in
an `if let` expression and then uses an approach similar to how we
handle loops to ensure that we reliably drop the correct variables.
    @matthewjasper
    matthewjasper committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    ff8c0ef View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. Remove TODO

    @matthewjasper
    matthewjasper committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    fd5b40f View commit details
    Browse the repository at this point in the history

  2. Bless 32bit MIR opt tests

    @matthewjasper
    matthewjasper committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    9366dfd View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2021

  1. Update coverage tests

    @matthewjasper
    matthewjasper committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    4e2fd4f View commit details
    Browse the repository at this point in the history