Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move confused_type_with_std_module to ResolverOutputs #88689

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

Aaron1011
Copy link
Member

This eliminates untracked global state from Session.

This eliminates untracked global state from `Session`.
@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 6, 2021
@cjgillot
Copy link
Contributor

cjgillot commented Sep 6, 2021

Calling resolutions can cause extra query invalidation, but this only modifies diagnostic code path. So...
@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 6, 2021
@bors
Copy link
Contributor

bors commented Sep 6, 2021

⌛ Trying commit 4044024 with merge 6e35adac56672c718b4b265cb54ae971f0786498...

@cjgillot cjgillot self-assigned this Sep 6, 2021
@bors
Copy link
Contributor

bors commented Sep 6, 2021

☀️ Try build successful - checks-actions
Build commit: 6e35adac56672c718b4b265cb54ae971f0786498 (6e35adac56672c718b4b265cb54ae971f0786498)

@rust-timer
Copy link
Collaborator

Queued 6e35adac56672c718b4b265cb54ae971f0786498 with parent 13db844, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6e35adac56672c718b4b265cb54ae971f0786498): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 6, 2021
@cjgillot
Copy link
Contributor

cjgillot commented Sep 6, 2021

@bors r+ rollup=maybe

@bors
Copy link
Contributor

bors commented Sep 6, 2021

📌 Commit 4044024 has been approved by cjgillot

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2021
@bors
Copy link
Contributor

bors commented Sep 7, 2021

⌛ Testing commit 4044024 with merge 385f8e2...

@bors
Copy link
Contributor

bors commented Sep 7, 2021

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 385f8e2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 7, 2021
@bors bors merged commit 385f8e2 into rust-lang:master Sep 7, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 7, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (385f8e2): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@Aaron1011 Aaron1011 deleted the confused-std-resolver branch September 8, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants