Rework DepthFirstSearch API #88711
Merged
Rework DepthFirstSearch API #88711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Mark-Simulacrum
force-pushed
the
fix-dfs-bug
branch
from
d60eaec
to
4717cfd
Compare
Mark-Simulacrum
changed the title
DepthFirstSearch where start node may be visited twice
|
Switched the commit in this PR to also include a later patch set reworking the API further and coincidentally fixing the bug previously noted. Should avoid wasting time on reviewing a soon to be unnecessary patch set, while still achieving the same goals as before. |
jackh726
approved these changes
Sep 8, 2021
|
r? @jackh726 r=me with/without nit |
This expands the API to be more flexible, allowing for more visitation patterns on graphs. This will be useful to avoid extra datasets (and allocations) in cases where the expanded DFS API is sufficient. This also fixes a bug with the previous DFS constructor, which left the start node not marked as visited (even though it was immediately returned).
Mark-Simulacrum
force-pushed
the
fix-dfs-bug
branch
from
4717cfd
to
c9d46eb
Compare
|
@bors r=jackh726 |
|
📌 Commit c9d46eb has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Sep 12, 2021
…h726 Rework DepthFirstSearch API This expands the API to be more flexible, allowing for more visitation patterns on graphs. This will be useful to avoid extra datasets (and allocations) in cases where the expanded DFS API is sufficient. This also fixes a bug with the previous DFS constructor, which left the start node not marked as visited (even though it was immediately returned). Commit written by `@nikomatsakis` originally, cherry picked from several commits in work on never type stabilization, but stands alone.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Sep 12, 2021
…h726 Rework DepthFirstSearch API This expands the API to be more flexible, allowing for more visitation patterns on graphs. This will be useful to avoid extra datasets (and allocations) in cases where the expanded DFS API is sufficient. This also fixes a bug with the previous DFS constructor, which left the start node not marked as visited (even though it was immediately returned). Commit written by ``@nikomatsakis`` originally, cherry picked from several commits in work on never type stabilization, but stands alone.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 12, 2021
…arth Rollup of 7 pull requests Successful merges: - rust-lang#88336 ( Detect stricter constraints on gats where clauses in impls vs trait) - rust-lang#88677 (rustc: Remove local variable IDs from `Export`s) - rust-lang#88699 (Remove extra unshallow from cherry-pick checker) - rust-lang#88709 (generic_const_exprs: use thir for abstract consts instead of mir) - rust-lang#88711 (Rework DepthFirstSearch API) - rust-lang#88810 (rustdoc: Cleanup `clean` part 1) - rust-lang#88813 (explicitly link to external `ena` docs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
The rollup caused an instruction count increase on perf, do you think that's due to this PR? |
|
It seems pretty unlikely, though not impossible. The only (that I can find) user of DFS today is the reverse scc computation here. As far as I can tell, that code certainly runs a lot, but I wouldn't expect a fundamental difference -- if anything, the new behavior should be a little faster since we're only returning the start node once (and not maybe twice). But it's hard to say. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the API to be more flexible, allowing for more visitation patterns
on graphs. This will be useful to avoid extra datasets (and allocations) in
cases where the expanded DFS API is sufficient.
This also fixes a bug with the previous DFS constructor, which left the start
node not marked as visited (even though it was immediately returned).
Commit written by @nikomatsakis originally, cherry picked from several commits in work on never type stabilization, but stands alone.