Allow missing code examples in trait impls. #88745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jyn514 (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
hnj2
commented
Sep 8, 2021
hnj2
commented
Sep 8, 2021
|
I don't have time to review this. |
|
Looks good overall, just a few nits and it's good to go, thanks! |
hnj2
force-pushed
the
allow-trait-impl-missing-code
branch
from
2fe7a51
to
c86c634
Compare
GuillaumeGomez
approved these changes
Sep 9, 2021
|
Looks good to me, thanks! Just waiting for CI then I r+ it. |
|
@bors: r+ |
|
📌 Commit c86c634 has been approved by |
bors
added
S-waiting-on-bors
jyn514
added
A-lint
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 9, 2021
… r=GuillaumeGomez Allow missing code examples in trait impls. Excludes Trait implementations from the items that need to have doc code examples when using the `rustdoc::missing_doc_code_examples` lint. For details see rust-lang#88741 fixes rust-lang#88741 r? `@jyn514`
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Sep 12, 2021
… r=GuillaumeGomez Allow missing code examples in trait impls. Excludes Trait implementations from the items that need to have doc code examples when using the `rustdoc::missing_doc_code_examples` lint. For details see rust-lang#88741 fixes rust-lang#88741 r? ``@jyn514``
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Sep 12, 2021
… r=GuillaumeGomez Allow missing code examples in trait impls. Excludes Trait implementations from the items that need to have doc code examples when using the `rustdoc::missing_doc_code_examples` lint. For details see rust-lang#88741 fixes rust-lang#88741 r? ```@jyn514```
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (1cd17ad): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excludes Trait implementations from the items that need to have doc code examples when using the
rustdoc::missing_doc_code_exampleslint.For details see #88741
fixes #88741
r? @jyn514