Rollup of 9 pull requests #88750
Merged
Rollup of 9 pull requests #88750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followup of rust-lang#83501, Fixes rust-lang#86253.
This implementation has no `Copy` or `Clone` bound, so its operation is guaranteed to be a move. The call site might copy, but the function itself cannot. Also linkify `Some` while we're touching the line anyway.
…rd's documentation page.
…r=camelid Rustdoc: Report Layout of enum variants Followup of rust-lang#83501, Fixes rust-lang#86253. cc `@camelid` `@rustbot` label A-rustdoc
… r=Mark-Simulacrum Add regression test for rust-lang#74400 Closes rust-lang#74400 by adding a regression test.
Improve diagnostics for unary plus operators (rust-lang#88276) This pull request improves the diagnostics emitted on parsing a unary plus operator. See rust-lang#88276. Before: ``` error: expected expression, found `+` --> src/main.rs:2:13 | 2 | let x = +1; | ^ expected expression ``` After: ``` error: leading `+` is not supported --> main.rs:2:13 | 2 | let x = +1; | ^ | | | unexpected `+` | help: try removing the `+` ```
… r=joshtriplett More symbolic doc aliases A bunch of small changes, mostly adding `#[doc(alias = "…")]` entries for symbolic `"…"`. Also a small change in documentation of `const` keywords.
Correct “copies” to “moves” in `<Option<T> as From<T>>::from` doc, and other copyediting The `impl<T> From<T> for Option<T>` has no `Copy` or `Clone` bound, so its operation is guaranteed to be a move. The call site might copy, but the function itself cannot. Since that would have been a rather small PR, I also reviewed the other documentation in the file and made other improvements (in separate commits): adding periods and commas, linking `Deref::Target`, and clarifying what "a container" is in `FromIterator`.
Add a regression test for rust-lang#88649 I noticed that rust-lang#88649 does not have a regression test, so I add one in this PR. The test fails with this without rust-lang#88678: ``` error[E0080]: evaluation of constant value failed --> /checkout/src/test/ui/consts/issue-88649.rs:13:52 | LL | Foo::Variant1(x) | Foo::Variant2(x) if x => {} | ^ StorageLive on a local that was already live error: aborting due to previous error For more information about this error, try `rustc --explain E0080`. ```
…mulacrum Drop 1.56 stabilizations from 1.55 release notes r? `@Mark-Simulacrum`
…shtriplett Fix docs for `uX::checked_next_multiple_of` Thanks to `@photino` for noticing this [here](rust-lang#88581 (comment)). r? `@joshtriplett` `@rustbot` label: +A-docs +A-waiting-on-review
Fix typo in `const_generics` replaced with `adt_const_params` note
|
@bors r+ rollup=never p=9 |
|
📌 Commit 4cb751e has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (47ae8de): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
<Option<T> as From<T>>::fromdoc, and other copyediting #88648 (Correct “copies” to “moves” in<Option<T> as From<T>>::fromdoc, and other copyediting)uX::checked_next_multiple_of#88712 (Fix docs foruX::checked_next_multiple_of)const_genericsreplaced withadt_const_paramsnote #88726 (Fix typo inconst_genericsreplaced withadt_const_paramsnote)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup