Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LLVM submodule #88765

Merged
merged 1 commit into from
Sep 12, 2021
Merged

Update LLVM submodule #88765

merged 1 commit into from
Sep 12, 2021

Conversation

mk12
Copy link
Contributor

@mk12 mk12 commented Sep 8, 2021

This merges upstream release/13.x changes to our fork. In particular,
this includes the bugfix https://reviews.llvm.org/D108608 (see also
https://bugs.llvm.org/show_bug.cgi?id=51637).

The motivation for this is fixing Rust coverage in Fuchsia: https://fxbug.dev/77427.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cuviper (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 8, 2021
@cuviper
Copy link
Member

cuviper commented Sep 8, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Sep 8, 2021

📌 Commit ae606a3185f82fb93c0856f2bd8343749c2075bc has been approved by cuviper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2021
This merges upstream `release/13.x` changes to our fork. In particular,
this includes the bugfix https://reviews.llvm.org/D108608 (see also
https://bugs.llvm.org/show_bug.cgi?id=51637).
@nikic
Copy link
Contributor

nikic commented Sep 10, 2021

I've updated the submodule to a slightly newer merge, as some fixes relevant for us have landed upstream in the meantime, in particular the one for #88769.

@bors r=cuviper rollup=never

@bors
Copy link
Contributor

bors commented Sep 10, 2021

📌 Commit 8bfd872 has been approved by cuviper

@bors
Copy link
Contributor

bors commented Sep 11, 2021

⌛ Testing commit 8bfd872 with merge 9748abc1c517202f0e36ef73b90f400b0c93b6c5...

@bors
Copy link
Contributor

bors commented Sep 11, 2021

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 11, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@nikic
Copy link
Contributor

nikic commented Sep 11, 2021

@bors retry timeout

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2021
@bors
Copy link
Contributor

bors commented Sep 12, 2021

⌛ Testing commit 8bfd872 with merge 0212c70...

@bors
Copy link
Contributor

bors commented Sep 12, 2021

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 0212c70 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 12, 2021
@bors bors merged commit 0212c70 into rust-lang:master Sep 12, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 12, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0212c70): comparison url.

Summary: This change led to moderate relevant mixed results 🤷 in compiler performance.

  • Moderate improvement in instruction counts (up to -0.7% on full builds of ctfe-stress-4)
  • Moderate regression in instruction counts (up to 0.7% on incr-unchanged builds of ripgrep)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

@rustbot rustbot added the perf-regression Performance regression. label Sep 12, 2021
@Mark-Simulacrum
Copy link
Member

@rustbot label: +perf-regression-triaged

This is necessary for us to keep up to date with upstream LLVM, and the changes here do not seem to merit deep investigation given their magnitude and relative scattering across positive/negative changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants