Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Cleanup clean part 1 #88810

Merged
merged 8 commits into from
Sep 12, 2021
Merged

rustdoc: Cleanup clean part 1 #88810

merged 8 commits into from
Sep 12, 2021

Commits on Sep 10, 2021

  1. Remove unnecessary Cache.*_did fields

    They can be obtained by accessing the `TyCtxt` where they are needed.
    camelid committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    44e6f2e View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2021

  1. Configuration menu
    Copy the full SHA
    df281ee View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0bb1c28 View commit details
    Browse the repository at this point in the history
  3. Create a valid Res in external_path()

    The order of the `where` bounds on auto trait impls changed because
    rustdoc currently sorts auto trait `where` bounds based on the `Debug`
    output for the bound. Now that the bounds have an actual `Res`, they are
    being unintentionally sorted by their `DefId` rather than their path.
    So, I had to update a test for the change in ordering of the rendered
    bounds.
    camelid committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    6a84d34 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c2207f5 View commit details
    Browse the repository at this point in the history
  5. Fix redundant arguments in external_path()

    If the path is for a trait, it is always true that `trait_did ==
    Some(did)`, so instead, `external_path()` now takes an `is_trait`
    boolean.
    camelid committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    5321b35 View commit details
    Browse the repository at this point in the history
  6. Remove unnecessary is_trait argument

    It was only used for sugaring `Fn` trait bounds, and rustdoc already
    checks that the `did` is for a `Fn` (or `FnMut`, `FnOnce`) lang item,
    so it's not necessary to also check that the `did` belongs to a trait.
    camelid committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    913764d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    280fc2d View commit details
    Browse the repository at this point in the history