-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: Cleanup clean
part 1
#88810
Merged
Merged
Commits on Sep 10, 2021
-
Remove unnecessary
Cache.*_did
fieldsThey can be obtained by accessing the `TyCtxt` where they are needed.
Configuration menu - View commit details
-
Copy full SHA for 44e6f2e - Browse repository at this point
Copy the full SHA 44e6f2eView commit details
Commits on Sep 11, 2021
-
Configuration menu - View commit details
-
Copy full SHA for df281ee - Browse repository at this point
Copy the full SHA df281eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bb1c28 - Browse repository at this point
Copy the full SHA 0bb1c28View commit details -
Create a valid
Res
inexternal_path()
The order of the `where` bounds on auto trait impls changed because rustdoc currently sorts auto trait `where` bounds based on the `Debug` output for the bound. Now that the bounds have an actual `Res`, they are being unintentionally sorted by their `DefId` rather than their path. So, I had to update a test for the change in ordering of the rendered bounds.
Configuration menu - View commit details
-
Copy full SHA for 6a84d34 - Browse repository at this point
Copy the full SHA 6a84d34View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2207f5 - Browse repository at this point
Copy the full SHA c2207f5View commit details -
Fix redundant arguments in
external_path()
If the path is for a trait, it is always true that `trait_did == Some(did)`, so instead, `external_path()` now takes an `is_trait` boolean.
Configuration menu - View commit details
-
Copy full SHA for 5321b35 - Browse repository at this point
Copy the full SHA 5321b35View commit details -
Remove unnecessary
is_trait
argumentIt was only used for sugaring `Fn` trait bounds, and rustdoc already checks that the `did` is for a `Fn` (or `FnMut`, `FnOnce`) lang item, so it's not necessary to also check that the `did` belongs to a trait.
Configuration menu - View commit details
-
Copy full SHA for 913764d - Browse repository at this point
Copy the full SHA 913764dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 280fc2d - Browse repository at this point
Copy the full SHA 280fc2dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.