Allow simd_shuffle to accept vectors of any length #88855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
calebzulawski
force-pushed
the
feature/simd_shuffle
branch
from
ddb15fd
to
1b3fe75
Compare
nagisa
reviewed
Sep 12, 2021
|
@bors r+ |
|
📌 Commit 1b3fe75 has been approved by |
bors
added
S-waiting-on-bors
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Sep 14, 2021
… r=nagisa Allow simd_shuffle to accept vectors of any length cc `@rust-lang/project-portable-simd` `@workingjubilee`
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Sep 14, 2021
… r=nagisa Allow simd_shuffle to accept vectors of any length cc ``@rust-lang/project-portable-simd`` ``@workingjubilee``
|
@bors r- |
bors
added
S-waiting-on-author
|
While experimenting with more complex actual uses of this than it was initially tested for, Caleb found a snag in the current version that causes an ICE if it is hit. Boxy helped draft a fix but we figured we might as well push a new revision here, since it seems like, due to recent queue issues, following up in another PR would take even longer. |
|
The simple tests I wrote did not catch that if the constant arg needed any evaluation, it was not monomorphized and crashed. I added a more complex test case that covers this scenario. Should be good to go now. |
|
@bors r+ |
|
📌 Commit 4a4ca94 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Sep 19, 2021
… r=nagisa Allow simd_shuffle to accept vectors of any length cc `@rust-lang/project-portable-simd` `@workingjubilee`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 19, 2021
Rollup of 10 pull requests Successful merges: - rust-lang#87960 (Suggest replacing an inexisting field for an unmentioned field) - rust-lang#88855 (Allow simd_shuffle to accept vectors of any length) - rust-lang#88966 (Check for shadowing issues involving block labels) - rust-lang#88996 (Fix linting when trailing macro expands to a trailing semi) - rust-lang#89017 (fix potential race in AtomicU64 time monotonizer) - rust-lang#89021 (Add a separate error for `dyn Trait` in `const fn`) - rust-lang#89051 (Add intra-doc links and small changes to `std::os` to be more consistent) - rust-lang#89053 (refactor: VecDeques IntoIter fields to private) - rust-lang#89055 (Suggest better place to add call parentheses for method expressions wrapped in parentheses) - rust-lang#89081 (Fix a typo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @rust-lang/project-portable-simd @workingjubilee