-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BENCH] Revert "Fix non-capturing closure return type coercion" #88926
Conversation
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 0414894 with merge cc08b15420582202a8bffdb12043459d014ffb75... |
☀️ Try build successful - checks-actions |
Queued cc08b15420582202a8bffdb12043459d014ffb75 with parent 9f85cd6, future comparison URL. |
Finished benchmarking commit (cc08b15420582202a8bffdb12043459d014ffb75): comparison url. Summary: This change led to very large relevant regressions 😿 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never |
Closing since we don't want to land; was just for perf. Thanks @workingjubilee |
Using to attempt to answer profiling questions raised in discussion in #88857
r? @ghost