[bootstrap] Improve the error message when ninja is not found to link to installation instructions
#89096
Conversation
…nk to installation instructions. Signed-off-by: Daira Hopwood <daira@jacaranda.org>
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
| You should install ninja as described at | ||
| <https://github.com/ninja-build/ninja/wiki/Pre-built-Ninja-packages>, | ||
| or set `download-ci-llvm = true` in the `[llvm]` section of `config.toml` | ||
| to download LLVM rather than building it. | ||
| " |
There was a problem hiding this comment.
I don't think this last suggestion is great - it might be useful in addition to suggesting ninja = false, but it shouldn't replace it altogether.
There was a problem hiding this comment.
Adding "ninja = false" didn't actually do anything as far as I could see. Is it working properly?
There was a problem hiding this comment.
It should be working ok. I think an issue is that if you run x.py once with the wrong ninja, then that gets cached in CMakeCache.txt, and then if you set ninja=false, the cached setup remains. Did you delete the llvm directory after changing the configuration? If not, then I suspect that is the cause.
There was a problem hiding this comment.
Yes that's consistent with what I saw. What can we do to improve that?
There was a problem hiding this comment.
I changed it to include both suggestions.
There was a problem hiding this comment.
What can we do to improve that?
Sorry, I'm not too familiar with cmake. I would maybe look at removing CMakeCache.txt at the beginning of the build, but would need to check with the regular llvm developers if that would cause a problem.
jyn514
added
the
T-bootstrap
|
@bors r+ rollup |
|
📌 Commit 23d6437 has been approved by |
bors
added
S-waiting-on-bors
Rollup of 12 pull requests Successful merges: - rust-lang#88795 (Print a note if a character literal contains a variation selector) - rust-lang#89015 (core::ascii::escape_default: reduce struct size) - rust-lang#89078 (Cleanup: Remove needless reference in ParentHirIterator) - rust-lang#89086 (Stabilize `Iterator::map_while`) - rust-lang#89096 ([bootstrap] Improve the error message when `ninja` is not found to link to installation instructions) - rust-lang#89113 (dont `.ensure()` the `thir_abstract_const` query call in `mir_build`) - rust-lang#89114 (Fixes a technicality regarding the size of C's `char` type) - rust-lang#89115 (:arrow_up: rust-analyzer) - rust-lang#89126 (Fix ICE when `indirect_structural_match` is allowed) - rust-lang#89141 (Impl `Error` for `FromSecsError` without foreign type) - rust-lang#89142 (Fix match for placeholder region) - rust-lang#89147 (add case for checking const refs in check_const_value_eq) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Rollup of 12 pull requests Successful merges: - rust-lang#88795 (Print a note if a character literal contains a variation selector) - rust-lang#89015 (core::ascii::escape_default: reduce struct size) - rust-lang#89078 (Cleanup: Remove needless reference in ParentHirIterator) - rust-lang#89086 (Stabilize `Iterator::map_while`) - rust-lang#89096 ([bootstrap] Improve the error message when `ninja` is not found to link to installation instructions) - rust-lang#89113 (dont `.ensure()` the `thir_abstract_const` query call in `mir_build`) - rust-lang#89114 (Fixes a technicality regarding the size of C's `char` type) - rust-lang#89115 (:arrow_up: rust-analyzer) - rust-lang#89126 (Fix ICE when `indirect_structural_match` is allowed) - rust-lang#89141 (Impl `Error` for `FromSecsError` without foreign type) - rust-lang#89142 (Fix match for placeholder region) - rust-lang#89147 (add case for checking const refs in check_const_value_eq) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
fixes #89091
Signed-off-by: Daira Hopwood daira@jacaranda.org