Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build abstract consts without typeck for fully qualified associated consts #89231

Closed
wants to merge 1 commit into from

Conversation

BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Sep 24, 2021

When we build an abstract const for the const arg in foo::<{ <T as Trait>::ASSOC }>() we currently typeck the anon constant and then build an abstract const by walking thir. this PR adds a special case for when the anon const is a fully qualified assoc const, instead of typeck'ing and using thir we will just lower it to to defid + substs pair where the defid is the associated item on the trait (the same result using thir would give us but without the cycles :P).

r? @lcnr

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 24, 2021
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
configure: rust.channel         := nightly
configure: rust.debug-assertions := True
configure: llvm.assertions      := True
configure: dist.missing-tools   := True
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure: 
configure: run `python /checkout/x.py --help`
configure: 
---
* highest error code: E0785
Found 501 error codes
Found 0 error codes with no tests
Done!
tidy error: /checkout/compiler/rustc_typeck/src/collect.rs:94: TODO is deprecated; use FIXME
some tidy checks failed



command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/rust-tidy" "/checkout" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "/checkout/obj/build" "16"


Build completed unsuccessfully in 0:00:12

@bors
Copy link
Contributor

bors commented Oct 21, 2021

☔ The latest upstream changes (presumably #90119) made this pull request unmergeable. Please resolve the merge conflicts.

@BoxyUwU
Copy link
Member Author

BoxyUwU commented Oct 23, 2021

gonna close this I dont think theres any point keeping it open, my point has been proven 🤣

@BoxyUwU BoxyUwU closed this Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants