Fix ICE caused by non_exaustive_omitted_patterns struct lint #89423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nadrieril
reviewed
Oct 1, 2021
DevinR528
force-pushed
the
reachable-fields
branch
from
2cd6ee7
to
2d2e655
Compare
|
☔ The latest upstream changes (presumably #89405) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
the
S-waiting-on-author
DevinR528
force-pushed
the
reachable-fields
branch
from
2d2e655
to
b06409e
Compare
|
LGTM! |
|
📌 Commit b06409e has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 5, 2021
…arth Rollup of 12 pull requests Successful merges: - rust-lang#87631 (os current_exe using same approach as linux to get always the full ab…) - rust-lang#88234 (rustdoc-json: Don't ignore impls for primitive types) - rust-lang#88651 (Use the 64b inner:monotonize() implementation not the 128b one for aarch64) - rust-lang#88816 (Rustdoc migrate to table so the gui can handle >2k constants) - rust-lang#89244 (refactor: VecDeques PairSlices fields to private) - rust-lang#89364 (rustdoc-json: Encode json files with UTF-8) - rust-lang#89423 (Fix ICE caused by non_exaustive_omitted_patterns struct lint) - rust-lang#89426 (bootstrap: add config option for nix patching) - rust-lang#89462 (haiku thread affinity build fix) - rust-lang#89482 (Follow the diagnostic output style guide) - rust-lang#89504 (Don't suggest replacing region with 'static in NLL) - rust-lang#89535 (fix busted JavaScript in error index generator) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
14 tasks
Nadrieril
added
the
F-non_exhaustive_omitted_patterns_lint
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 10, 2021
…Nadrieril,camelid Feature gate the non_exhaustive_omitted_patterns lint Fixes rust-lang#89374 Add the machinery to gate the new `non_exhaustive_omitted_patterns` lint. relates to rust-lang#89105 and rust-lang#89423
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 10, 2021
…Nadrieril,camelid Feature gate the non_exhaustive_omitted_patterns lint Fixes rust-lang#89374 Add the machinery to gate the new `non_exhaustive_omitted_patterns` lint. relates to rust-lang#89105 and rust-lang#89423
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 10, 2021
…Nadrieril,camelid Feature gate the non_exhaustive_omitted_patterns lint Fixes rust-lang#89374 Add the machinery to gate the new `non_exhaustive_omitted_patterns` lint. relates to rust-lang#89105 and rust-lang#89423
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #89382
Add check that a list of
Pats is non empty to prevent ICE inFnCtxt::lint_non_exhaustive_omitted_patterns.Is related to #89374 and #89105