Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only register WSACleanup if WSAStartup is actually ever called #89472

Merged
merged 3 commits into from
Oct 4, 2021
Merged

Only register WSACleanup if WSAStartup is actually ever called #89472

merged 3 commits into from
Oct 4, 2021

Commits on Oct 2, 2021

  1. Only register WSACleanup if WSAStartup is actually ever called

    @CDirkx @nagisa
    CDirkx authored and nagisa committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    9a6f2e6 View commit details
    Browse the repository at this point in the history

  2. Add test for checking if WS2_32.dll is linked

    @CDirkx @nagisa
    CDirkx authored and nagisa committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    b7d2b46 View commit details
    Browse the repository at this point in the history

  3. Run the rust-lang#85441 regression test on MSVC only 

    On MinGW toolchains the various features (such as function sections)
necessary to eliminate dead function references are disabled due to
various bugs. This means that the windows sockets library will most
likely remain linked to any mingw toolchain built program that also
utilizes libstd.

That said, I made an attempt to also enable `function-sections` and
`--gc-sections` during my experiments, but the symbol references
remained, sadly.
    @nagisa
    nagisa committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    5b4873a View commit details
    Browse the repository at this point in the history