-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test performance impact of removing untracked vtable cache from tcx #89602
Conversation
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 553a808 with merge 73d3bab7d9a52285b2738553971a9ab6f4a6cf11... |
☀️ Try build successful - checks-actions |
Queued 73d3bab7d9a52285b2738553971a9ab6f4a6cf11 with parent d7539a6, future comparison URL. |
Finished benchmarking commit (73d3bab7d9a52285b2738553971a9ab6f4a6cf11): comparison url. Summary: This change led to moderate relevant regressions 😿 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never |
This is probably due to https://github.com/rust-lang/rustc-perf/blob/c7680837bb2b0a781ec2d7f1025b155ac64c0bc5/collector/benchmarks/ctfe-stress-4/src/lib.rs#L67 generating the same vtable a couple thousand times. It's fine to regress this stress test in this way |
Alright, good to know we might have a simple fix if we can't do a proper one in time. |
See #89598 for more information