Rollup of 8 pull requests #89696
Closed
Rollup of 8 pull requests #89696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the release notes and its PR milestone, it was stabilized in 1.56.0.
This commit changes the `tracing_subscriber` initialization in `rustc_driver` so that the `WARN` verbosity level is enabled by default when the `RUSTC_LOG` env variable is empty. If the `RUSTC_LOG` env variable is set, the filter string in the environment variable is honored, instead. Fixes rust-lang#76824 Closes rust-lang#89623 cc @eddyb, @oli-obk
Co-authored-by: Joshua Nelson <github@jyn.dev>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
T_____T Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
callers of spawn_unchecked() need to make sure that the thread not outlive references in the passed closure, not the other way around.
These methods could be misconstrued as modifying their arguments instead of returning new values. Where possible I made the note recommend a method that does mutate in place.
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
String.split_terminator: Add an example when using a slice of chars
Fix stabilization version for `bindings_after_at` According to the release notes and its PR milestone, it was stabilized in 1.56.0.
rustc_driver: Enable the `WARN` log level by default This commit changes the `tracing_subscriber` initialization in `rustc_driver` so that the `WARN` verbosity level is enabled by default when the `RUSTC_LOG` env variable is empty. If the `RUSTC_LOG` env variable is set, the filter string in the environment variable is honored, instead. Fixes rust-lang#76824 Closes rust-lang#89623 cc `@eddyb,` `@oli-obk`
…lett Fix minor std::thread documentation typo callers of spawn_unchecked() need to make sure that the thread not outlive references in the passed closure, not the other way around.
…iplett Fix asm docs typo Fixes a typo in target feature names in the `asm` documentation
…ed, r=Mark-Simulacrum Move `read2_abbreviated` function into read2.rs Work towards rust-lang#89475.
…err-locks, r=joshtriplett Add #[must_use] to stdin/stdout/stderr locks Affected methods: ```rust std::io fn stdin_locked() -> StdinLock<'static>; std::io::Stdin fn lock(&self) -> StdinLock<'_>; std::io fn stdout_locked() -> StdoutLock<'static>; std::io::Stdout fn lock(&self) -> StdoutLock<'_>; std::io fn stderr_locked() -> StderrLock<'static>; std::io::Stderr fn lock(&self) -> StderrLock<'_>; ``` Parent issue: rust-lang#89692
…s, r=joshtriplett Add #[must_use] to string/char transformation methods These methods could be misconstrued as modifying their arguments instead of returning new values. Where possible I made the note recommend a method that does mutate in place. Parent issue: rust-lang#89692
|
@bors r+ rollup=never p=8 |
|
📌 Commit a2caa35 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit a2caa35 with merge ef575b7e6f465cd3e34528a20814fb4a3c911ad4... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
Looks like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
bindings_after_at#89605 (Fix stabilization version forbindings_after_at)WARNlog level by default #89634 (rustc_driver: Enable theWARNlog level by default)read2_abbreviatedfunction into read2.rs #89687 (Moveread2_abbreviatedfunction into read2.rs)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup