Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config.toml overflow-checks options #89828

Merged
merged 4 commits into from
Oct 13, 2021

Conversation

hkratz
Copy link
Contributor

@hkratz hkratz commented Oct 12, 2021

This a follow-up PR to #87784.

Improvements:

  • Add missing entries for overflow-checks to config.toml.example.
  • Add --enable-overflow-checks-std option to configure script.
  • Make rust.overflow-checks-stdoption default to rust.overflow-checks.

Also adds the missing --enable-debug-assertions-std option to configure script.

r? @Mark-Simulacrum
cc @jyn514

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 12, 2021
@rust-log-analyzer

This comment has been minimized.

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

Thanks!

@bors
Copy link
Contributor

bors commented Oct 13, 2021

📌 Commit 905ed5f has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 13, 2021
…take-two, r=Mark-Simulacrum

Fix config.toml overflow-checks options

This a follow-up PR to rust-lang#87784.

Improvements:
* Add missing entries for overflow-checks to config.toml.example.
* Add --enable-overflow-checks-std option to configure script.
* Make rust.overflow-checks-stdoption default to rust.overflow-checks.

Also adds the missing  `--enable-debug-assertions-std `option to configure script.

r? `@Mark-Simulacrum`
cc `@jyn514`
the8472 added a commit to the8472/rust that referenced this pull request Oct 13, 2021
…take-two, r=Mark-Simulacrum

Fix config.toml overflow-checks options

This a follow-up PR to rust-lang#87784.

Improvements:
* Add missing entries for overflow-checks to config.toml.example.
* Add --enable-overflow-checks-std option to configure script.
* Make rust.overflow-checks-stdoption default to rust.overflow-checks.

Also adds the missing  `--enable-debug-assertions-std `option to configure script.

r? ``@Mark-Simulacrum``
cc ``@jyn514``
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 13, 2021
Rollup of 12 pull requests

Successful merges:

 - rust-lang#89768 (add some more testcases)
 - rust-lang#89777 (Edit explanation of test for nested type ascriptions)
 - rust-lang#89781 (Add missing words in `Infallible` docs)
 - rust-lang#89782 (Improve CJK font in rustdoc)
 - rust-lang#89794 (Add #[must_use] to to_value conversions)
 - rust-lang#89814 (Fix uppercase/lowercase error)
 - rust-lang#89816 (Fix invalid rules in .gitignore)
 - rust-lang#89817 (Add #[inline] to int log10 functions.)
 - rust-lang#89818 (Use Option::map_or instead of open coding it)
 - rust-lang#89828 (Fix config.toml overflow-checks options)
 - rust-lang#89840 (fix the stage0 tools config file path in `config.toml.example`)
 - rust-lang#89845 (Add davidtwco to the `.mailmap`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 72626bf into rust-lang:master Oct 13, 2021
@rustbot rustbot added this to the 1.57.0 milestone Oct 13, 2021
@hkratz hkratz deleted the overflow-check-options-take-two branch November 6, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants