Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perf only] Test inliner patch #89830

Closed
wants to merge 1 commit into from
Closed

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Oct 12, 2021

Testing impact of https://reviews.llvm.org/D98481, which would address #89524.

r? @ghost

@nikic
Copy link
Contributor Author

nikic commented Oct 12, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 12, 2021
@bors
Copy link
Contributor

bors commented Oct 12, 2021

⌛ Trying commit 98b1804 with merge b0d79486ff8b43e7be9999d567ba9af725d81544...

@bors
Copy link
Contributor

bors commented Oct 12, 2021

☀️ Try build successful - checks-actions
Build commit: b0d79486ff8b43e7be9999d567ba9af725d81544 (b0d79486ff8b43e7be9999d567ba9af725d81544)

@rust-timer
Copy link
Collaborator

Queued b0d79486ff8b43e7be9999d567ba9af725d81544 with parent 9475e60, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b0d79486ff8b43e7be9999d567ba9af725d81544): comparison url.

Summary: This change led to large relevant regressions 😿 in compiler performance.

  • Large regression in instruction counts (up to 1.0% on incr-unchanged builds of deep-vector)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 12, 2021
@apiraino apiraino added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Oct 14, 2021
@nikic nikic closed this Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants