Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't emit a warning for empty rmeta files. #90072

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Don't emit a warning for empty rmeta files. #90072

merged 1 commit into from
Oct 21, 2021

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Oct 20, 2021

This avoids displaying a warning when attempting to load an empty rmeta file. Warnings were enabled via #89634 which can cause a lot of noise (for example, running ./x.py check). rustc generates empty rmeta files for things like binaries, which can happen when checking libraries as unittests.

Closes #89795

@rust-highfive
Copy link
Collaborator

r? @cjgillot

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2021
@ehuss ehuss added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 20, 2021
@ehuss
Copy link
Contributor Author

ehuss commented Oct 20, 2021

Nominating for beta just to avoid the warning spam when running x.py (after #90042).

@Mark-Simulacrum
Copy link
Member

@bors r+ p=1

I think this makes sense. FWIW, it may be worth putting in the effort to avoid the user-visible tracing warnings, because they don't provide guidance on what to do -- we should strive to not give such warnings to users, IMO. Unconditional warnings with a help: text would already be an improvement.

cc @petrochenkov

@bors
Copy link
Contributor

bors commented Oct 21, 2021

📌 Commit 6f91505 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2021
@bors
Copy link
Contributor

bors commented Oct 21, 2021

⌛ Testing commit 6f91505 with merge 40ebd07...

@bors
Copy link
Contributor

bors commented Oct 21, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 40ebd07 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 21, 2021
@bors bors merged commit 40ebd07 into rust-lang:master Oct 21, 2021
@rustbot rustbot added this to the 1.58.0 milestone Oct 21, 2021
@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 21, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (40ebd07): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@apiraino
Copy link
Contributor

Beta backport accepted as per compiler team on Zulip

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 21, 2021
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 22, 2021
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.58.0, 1.57.0 Oct 22, 2021
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Oct 22, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 22, 2021
@bors
Auto merge of rust-lang#90151 - Mark-Simulacrum:beta-next, r=Mark-Sim…
7e4c9ee 
…ulacrum

[beta] backports

*  Don't emit a warning for empty rmeta files. rust-lang#90072
*  Erase late-bound regions before computing vtable debuginfo name. rust-lang#90050
*  Fix wrong niche calculation when 2+ niches are placed at the start rust-lang#90040
*  Revert rust-lang#86011 to fix an incorrect bound check rust-lang#90025
*  Fix macro_rules! duplication when reexported in the same module rust-lang#89867
* Bump cargo to include rust-lang/cargo#9979 - Fix fetching git repos after a force push.

r? `@Mark-Simulacrum`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.57.0
Development

Successfully merging this pull request may close these issues.

failed to mmap rmeta metadata
8 participants
@ehuss @rust-highfive @Mark-Simulacrum @bors @rust-timer @apiraino @cjgillot @rustbot