Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SortedMap in HIR. #90145

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Use SortedMap in HIR. #90145

merged 1 commit into from
Oct 28, 2021

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Oct 21, 2021 •
edited
Loading

Closes #89788
r? @ghost

@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 21, 2021
@bors
Copy link
Contributor

bors commented Oct 21, 2021

⌛ Trying commit 6f6fa8b with merge a1491dd86bcdb6c387f2fe93a6d6205aafce0fed...

@bors
Copy link
Contributor

bors commented Oct 21, 2021

☀️ Try build successful - checks-actions
Build commit: a1491dd86bcdb6c387f2fe93a6d6205aafce0fed (a1491dd86bcdb6c387f2fe93a6d6205aafce0fed)

@rust-timer
Copy link
Collaborator

Queued a1491dd86bcdb6c387f2fe93a6d6205aafce0fed with parent 547a6ff, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a1491dd86bcdb6c387f2fe93a6d6205aafce0fed): comparison url.

Summary: This change led to moderate relevant improvements 🎉 in compiler performance.

  • Moderate improvement in instruction counts (up to -0.8% on incr-unchanged builds of unicode_normalization)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 22, 2021
@cjgillot
Copy link
Contributor Author

r? @michaelwoerister

@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 28, 2021
@michaelwoerister
Copy link
Member

Seems to work out quite nicely -- thanks, @cjgillot!

@bors r+

@bors
Copy link
Contributor

bors commented Oct 28, 2021

📌 Commit 6f6fa8b has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2021
@bors
Copy link
Contributor

bors commented Oct 28, 2021

⌛ Testing commit 6f6fa8b with merge c4ff03f...

@bors
Copy link
Contributor

bors commented Oct 28, 2021

☀️ Test successful - checks-actions
Approved by: michaelwoerister
Pushing c4ff03f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 28, 2021
@bors bors merged commit c4ff03f into rust-lang:master Oct 28, 2021
@rustbot rustbot added this to the 1.58.0 milestone Oct 28, 2021
@bors bors mentioned this pull request Oct 28, 2021
Merged
@cjgillot cjgillot deleted the sorted-map branch October 28, 2021 17:18
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c4ff03f): comparison url.

Summary: This change led to moderate relevant improvements 🎉 in compiler performance.

  • Moderate improvement in instruction counts (up to -0.8% on incr-unchanged builds of unicode_normalization)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.

Investigate using rustc_data_structures::sorted_map::SortedMap for HIR
6 participants
@cjgillot @rust-timer @bors @michaelwoerister @apiraino @rustbot