Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repace use of static_nobundle with native_link_modifiers within Rust codebase #90205

Merged
merged 2 commits into from
Oct 30, 2021
Merged

Repace use of static_nobundle with native_link_modifiers within Rust codebase #90205

merged 2 commits into from
Oct 30, 2021

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Oct 23, 2021

This fixes warnings when building Rust and running tests:

warning: library kind `static-nobundle` has been superseded by specifying `-bundle` on library kind `static`. Try `static:-bundle`
warning: `rustc_llvm` (lib) generated 2 warnings (1 duplicate)

@mati865
Repace use of static_nobundle with native_link_modifiers
a076f2b 
This fixes warning when building Rust and running tests:
```
warning: library kind `static-nobundle` has been superseded by specifying `-bundle` on library kind `static`. Try `static:-bundle`
warning: `rustc_llvm` (lib) generated 2 warnings (1 duplicate)
```
@rust-highfive
Copy link
Collaborator

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 23, 2021
@petrochenkov
Copy link
Contributor

r? @petrochenkov @bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 23, 2021

📌 Commit a076f2b has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 23, 2021
@matthiaskrgr
Rollup merge of rust-lang#90205 - mati865:link-modifiers-in-rustc, r=…
0cf784d 
…petrochenkov

Repace use of `static_nobundle` with `native_link_modifiers` within Rust codebase

This fixes warnings when building Rust and running tests:
```
warning: library kind `static-nobundle` has been superseded by specifying `-bundle` on library kind `static`. Try `static:-bundle`
warning: `rustc_llvm` (lib) generated 2 warnings (1 duplicate)
```
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 23, 2021
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 24, 2021
@matthiaskrgr
Rollup merge of rust-lang#90205 - mati865:link-modifiers-in-rustc, r=…
f5e1dd9 
…petrochenkov

Repace use of `static_nobundle` with `native_link_modifiers` within Rust codebase

This fixes warnings when building Rust and running tests:
```
warning: library kind `static-nobundle` has been superseded by specifying `-bundle` on library kind `static`. Try `static:-bundle`
warning: `rustc_llvm` (lib) generated 2 warnings (1 duplicate)
```
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 24, 2021
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 24, 2021
@matthiaskrgr
Rollup merge of rust-lang#90205 - mati865:link-modifiers-in-rustc, r=…
bdf54db 
…petrochenkov

Repace use of `static_nobundle` with `native_link_modifiers` within Rust codebase

This fixes warnings when building Rust and running tests:
```
warning: library kind `static-nobundle` has been superseded by specifying `-bundle` on library kind `static`. Try `static:-bundle`
warning: `rustc_llvm` (lib) generated 2 warnings (1 duplicate)
```
This was referenced Oct 24, 2021
Closed
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 24, 2021
@matthiaskrgr
Rollup merge of rust-lang#90205 - mati865:link-modifiers-in-rustc, r=…
0ffdb63 
…petrochenkov

Repace use of `static_nobundle` with `native_link_modifiers` within Rust codebase

This fixes warnings when building Rust and running tests:
```
warning: library kind `static-nobundle` has been superseded by specifying `-bundle` on library kind `static`. Try `static:-bundle`
warning: `rustc_llvm` (lib) generated 2 warnings (1 duplicate)
```
@matthiaskrgr
Copy link
Member

@bors r- failed in a rollup: #90226 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 24, 2021
@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 28, 2021
@mati865
Copy link
Contributor Author

mati865 commented Oct 29, 2021

Somehow most of run-make* tests were previously ignored, still there are many ignored but at least the tests that failed on CI passed.
Let me know if I should drop tests changes or squash it.

@petrochenkov petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 29, 2021
@petrochenkov
Copy link
Contributor

petrochenkov commented Oct 29, 2021 •
edited
Loading

Let me know if I should drop tests changes

Nah, static-nobundle will (hopefully) soon be removed anyway, so the tests will need to be updated too.
@bors r+

@bors
Copy link
Contributor

bors commented Oct 29, 2021

📌 Commit 533247c has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 30, 2021
@matthiaskrgr
Rollup merge of rust-lang#90205 - mati865:link-modifiers-in-rustc, r=…
b594127 
…petrochenkov

Repace use of `static_nobundle` with `native_link_modifiers` within Rust codebase

This fixes warnings when building Rust and running tests:
```
warning: library kind `static-nobundle` has been superseded by specifying `-bundle` on library kind `static`. Try `static:-bundle`
warning: `rustc_llvm` (lib) generated 2 warnings (1 duplicate)
```
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 30, 2021
Closed
@matthiaskrgr
Copy link
Member

@bors rollup=iffy

@bors
Copy link
Contributor

bors commented Oct 30, 2021

⌛ Testing commit 533247c with merge 2609fab...

@bors
Copy link
Contributor

bors commented Oct 30, 2021

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 2609fab to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 30, 2021
@bors bors merged commit 2609fab into rust-lang:master Oct 30, 2021
@rustbot rustbot added this to the 1.58.0 milestone Oct 30, 2021
@mati865 mati865 deleted the link-modifiers-in-rustc branch October 30, 2021 19:52
@bors bors mentioned this pull request Oct 30, 2021
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2609fab): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.
9 participants
@mati865 @rust-highfive @petrochenkov @bors @matthiaskrgr @rust-timer @estebank @apiraino @rustbot