Let var hygiene #9026
Closed
Let var hygiene #9026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... it would also have been possible to add all of their dependencies, but that would have increased the already-lengthy list of parameters. Also, if we had macros that could expand into macro defns, you could stage it. This seemed like the least painful choice.
|
Could use some squashes. |
See the comments for details on why I'm leaving this code in, though commented out.
also adds test cases
…e comparison in others
resolve must ignore syntax context when comparing module names
this is necessary so that the new idents are connected to the original strings. this is important both for error messages, and so that top-level refs get connected to the right things.
This is actually almost a problem, because those were my poster-child macros for "here's how to implement a capturing macro." Following this change, there will be no macros that use capturing; this will probably make life unpleasant for the first person that wants to implement a capturing macro. I should probably create a dummy_capturing macro, just to show how it works.
|
@adridu59 re: squashes: if you want to see the whole diff at once, github's interface will show you that. I've spent 40+hours rebasing and cleaning up, so my budget is a little squeezed... if there are particular sets of commits you'd like me to try to squash, though, I'd be happy to take a look at them |
bors
added a commit
that referenced
this pull request
Sep 7, 2013
This is a rebase of my approved pull request from ... the end of June? It introduces hygiene for let-bound variables.
|
\o/ Finally! :) |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 30, 2022
…Frednet put parentheses around neg_multiply suggestion if needed *Please write a short comment explaining your change (or "none" for internal only changes)* changelog: [`neg_multiply`]: put parentheses around suggestion if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of my approved pull request from ... the end of June? It introduces hygiene for let-bound variables.