Add missing documentation for doc alias #90339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
the
T-rustdoc
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @camelid |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
doc-alias-doc
branch
from
e6915c7
to
23c81a0
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
doc-alias-doc
branch
from
23c81a0
to
b229271
Compare
camelid
reviewed
Oct 27, 2021
| @@ -153,7 +153,7 @@ example, if you want your doctests to fail if they produce any warnings, you cou | |||
| These forms of the `#[doc]` attribute are used on individual items, to control how | |||
| they are documented. | |||
|
|
|||
| ## `#[doc(no_inline)]`/`#[doc(inline)]` | |||
| ### `#[doc(no_inline)]`/`#[doc(inline)]` | |||
There was a problem hiding this comment.
Can you open a followup PR to replace this with
Suggested change
| ### `#[doc(no_inline)]`/`#[doc(inline)]` | |
| ### `no_inline` and `inline` |
(and #[doc(hidden)] below with hidden) for consistency with the earlier parts of this page? In that PR, you'll also need to edit at least one error message that links to this header; it'd probably also be a good idea to add a link target for the old name, something like <span id="docno_inlinedocinline">.
camelid
added
A-docs
GuillaumeGomez
force-pushed
the
doc-alias-doc
branch
from
b229271
to
47786d3
Compare
|
📌 Commit 47786d3 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (f2707fe): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 30, 2021
…itles, r=camelid Unify titles in rustdoc book doc attributes chapter As discussed in rust-lang#90339. I wasn't able to find out where the link to the titles was used so let's see if the CI fails. :) r? `@camelid`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 30, 2021
…itles, r=camelid Unify titles in rustdoc book doc attributes chapter As discussed in rust-lang#90339. I wasn't able to find out where the link to the titles was used so let's see if the CI fails. :) r? ``@camelid``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.