rustdoc: Switch to mainline rayon #90389
Conversation
The rustc fork of rayon integrates with Cargo's jobserver to limit the amount of parallelism. However, rustdoc's use case is concurrent I/O, which is not CPU-heavy, so it should be able to use mainline rayon. See this discussion [1] for more details. [1]: rust-lang#90227 (comment) Note: I chose rayon 1.3.1 so that the rayon version used elsewhere in the workspace does not change.
camelid
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
|
The code using rustc-rayon was originally added in #60971. @rbtcollins was there a particular reason you used rustc-rayon instead of mainline rayon, or should it be fine to change? (Also cc @GuillaumeGomez, who worked on that change as well.) |
|
Also, it looks like rustc-rayon and rayon 1.3.1 are fairly similar, but I'm not certain. |
|
I think a perf run probably won't measure anything because rustc-perf uses Linux, right? |
|
Just in case (and so perf could be measured independently from rustc-perf if people so choose): @bors rollup=never |
Correct, I ran into the same trouble in #88219. |
I think the new code is simpler and easier to understand.
|
I don't think it'll impact performance in any case so should be fine. |
|
No reason to prefer one over the other that o know of.
…On Fri, 29 Oct 2021, 13:54 Guillaume Gomez, ***@***.***> wrote:
I don't think it'll impact performance in any case so should be fine.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#90389 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADZ7XUS4MQ6KRGBBZNLKCLUJKKQZANCNFSM5G6GA7LQ>
.
|
|
@bors r+ |
|
📌 Commit 581dc75 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (deb4572): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
The rustc fork of rayon integrates with Cargo's jobserver to limit the
amount of parallelism. However, rustdoc's use case is concurrent I/O,
which is not CPU-heavy, so it should be able to use mainline rayon.
See this discussion for more details.
Note: I chose rayon 1.3.1 so that the rayon version used elsewhere in
the workspace does not change.
r? @Mark-Simulacrum
cc @jyn514