-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update rustc_ast crate descriptions in documentation #90518
Conversation
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
@@ -1,6 +1,5 @@ | |||
The `rustc_ast` crate contains those things concerned purely with syntax | |||
– that is, the AST ("abstract syntax tree"), parser, pretty-printer, | |||
lexer, macro expander, and utilities for traversing ASTs. | |||
– that is, the AST ("abstract syntax tree"), along with some definitions for tokens and token streams, data structures/traits for mutating ASTs, and shared definitions for other AST-related parts of the compiler (like the lexer and macro-expansion). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I'm not even sure why this file exists. I thought all the compiler/
READMEs were moved to the rustc-dev-guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd assume that's because this gets published to crates.io as part of the auto publish process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see 👍
Thanks! @bors r+ rollup |
📌 Commit 9e31fab has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (27143a9): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
I noticed this the other day and figured I'd suggest a refresh. It seems like a relic from the days of
libsyntax
that got missed as things were split out into separate crates, since the current documentation text references elements that were moved into their own respective crates (e.g.rustc_parse
)