-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for PlayStation Vita #90584
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon. Please see the contribution instructions for more information. |
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Please quote the requirements and questions from the tier 3 target policy and reply to them. |
The target maintainer is just myself at the time of writing.
The target name is
VitaSDK toolchain and headers are under MIT license.
Support for this platform is licensed under MIT license as well.
The only dependencies needed are the libc used by the Vita SDK, licensed under GPL (I think there are no issues with that). It also needs a pthread implementation, which is under MIT license.
There is no intended support for building host tools.
I believe it is not the case.
Understood.
At the moment only the
I'd need some guidance with this. Tell me please where in the docs I must address these building instructions for the target. About test running support, it is not taken into account at the time of writing.
Understood.
Understood.
I'm fine with it. |
The PlayStation Vita is EoL, so I think the legal situation is more closely related to the existing 3DS and PSP targets. |
@amg98
You should add a file in |
triage: @rustbot label: +S-waiting-on-author -S-waiting-on-review |
I think Josh's comment has been addressed but this is still blocked on policy discussions like #88991 is. |
☔ The latest upstream changes (presumably #93220) made this pull request unmergeable. Please resolve the merge conflicts. |
Hi @amg98! I'm sorry this has taken so long to get sorted out but the policy decisions around this PR and related PRs like #88991 have been resolved and we believe there is no reason not to accept these new targets. If you can rebase this PR and resolve the merge conflicts, we can go ahead and merge this. Thanks! 🙂 |
@amg98 any updates on this? |
@Dylan-DPC Hi!! Sorry for the delay, I've been quite inactive in github recently. I'll try to get some time to solve the conflicts so we can merge this PR soon |
@amg98 that's fine no worries. |
I don't think you intended to close this and rebased wrongly? |
Yep, I messed that up, I reopened the PR here (#105606) |
Just the compiler definitions for no-std projects. When merged I'll PR again with the std library adaptation.