Rollup of 9 pull requests #90598
Merged
Rollup of 9 pull requests #90598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since rustc doesn't do the assembly parsing itself, it is unable to detect when inline assembly ends with an instruction prefix, which doesn't make sense since it would apply to instructions from the compiler. This fixes rust-lang#82314 by mentioning that x86 instruction prefixes must not be used in inline assembly.
Inspired by rust-lang#90521 , and by the various `must_use` PRs; in all of those cases, the submitter of the PR could know that `relnotes` applied, but couldn't apply it themselves.
People should be able to help triage by observing that a change needs an FCP before we can apply it.
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
… r=jackh726 Suggest `extern crate alloc` when using undeclared module `alloc` closes rust-lang#90136
…r=notriddle Simplify js tester a bit r? `````@notriddle`````
Add note about x86 instruction prefixes in asm! to unstable book Since rustc doesn't do the assembly parsing itself, it is unable to detect when inline assembly ends with an instruction prefix, which doesn't make sense since it would apply to instructions from the compiler. This fixes rust-lang#82314 by mentioning that x86 instruction prefixes must not be used in inline assembly. AFAICT x86 is the only instruction set with instruction prefixes.
…ure, r=Amanieu Update aarch64 `target_feature` list for LLVM 12. Many of these feature are now available on all valid LLVM versions. I've also added a few new ones to the list. r? `@Amanieu`
…henkov Demote metadata load warning to "info". There is a warn log message for whenever the crate loader fails to load metadata from a candidate file. I think this warning is too aggressive, as there are several situations where metadata information might not be found in a candidate file, which is normal. Also, this warning is somewhat confusing, and non-actionable in most cases for a user (most users will not know what it means). If the crate loader ultimately does not find a valid crate, then an error will be reported (and hopefully rust-lang#88368 will improve that error message). If a rustc developer wants to debug a loader problem, they can still use `RUSTC_LOG=rustc_metadata=debug` and get the details. There is more discussion of this particular warning at rust-lang#89795 (comment). Fixes rust-lang#90525
…oshtriplett Clean up some `-Z unstable-options` in tests. Several of these tests were for features that have been stabilized, or otherwise don't need `-Z unstable-options`.
…riplett
Add more text and examples to `carrying_{add|mul}`
`feature(bigint_helper_methods)` tracking issue rust-lang#85532
cc `````@clarfonthey`````
…r=Mark-Simulacrum rustbot allow labels `relnotes` was inspired by rust-lang#90521 , and by the various `must_use` PRs; in all of those cases, the submitter of the PR could know that `relnotes` applied, but couldn't apply it themselves. For `needs-fcp`, I think people should be able to help triage by observing that a change needs an FCP before we can apply it.
…r-sidebar, r=jsha Fix missing bottom border for headings in sidebar Fixes rust-lang#90568. r? ```@jsha```
|
@bors r+ p=9 rollup=never |
|
📌 Commit 3821ab2 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Nov 5, 2021
|
Finished benchmarking commit (b99bd8f): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
extern crate allocwhen using undeclared modulealloc#90507 (Suggestextern crate allocwhen using undeclared modulealloc)target_featurelist for LLVM 12. #90537 (Update aarch64target_featurelist for LLVM 12.)-Z unstable-optionsin tests. #90554 (Clean up some-Z unstable-optionsin tests.)carrying_{add|mul}#90556 (Add more text and examples tocarrying_{add|mul})Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup