use matches!() macro in more places #90642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occured to the CTFE / Miri engine cc @rust-lang/miri Some changes occured to the CTFE / Miri engine cc @rust-lang/miri |
|
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
cjgillot
reviewed
Nov 6, 2021
| ty::BoundConstness::ConstIfConst if self.is_in_const_context => true, | ||
| _ => false, | ||
| } | ||
| matches!(pred.constness, ty::BoundConstness::ConstIfConst if self.is_in_const_context) |
There was a problem hiding this comment.
Suggested change
| matches!(pred.constness, ty::BoundConstness::ConstIfConst if self.is_in_const_context) | |
| matches!(pred.constness, ty::BoundConstness::ConstIfConst) && self.is_in_const_context |
compiler/rustc_typeck/src/structured_errors/wrong_number_of_generic_args.rs
Outdated
Show resolved
Hide resolved
cjgillot
added
S-waiting-on-author
fbstj
reviewed
Nov 6, 2021
| | Ok(Some(ImplSource::Param(_, ty::BoundConstness::ConstIfConst))) => false, | ||
| _ => true, | ||
| } | ||
| | Ok(Some(ImplSource::Param(_, ty::BoundConstness::ConstIfConst))) |
There was a problem hiding this comment.
is this a candidate for "interior patterns": Ok(Some(ImplSource::ConstDrop(_) | ImplSource::Param(...)))
matthiaskrgr
force-pushed
the
clippy_matches
branch
from
5585ffb
to
5aa9688
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
matthiaskrgr
force-pushed
the
clippy_matches
branch
from
5aa9688
to
0a5640b
Compare
|
@bors r+ rollup |
|
📌 Commit 0a5640b has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 6, 2021
…llot use matches!() macro in more places
This was referenced Nov 6, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 6, 2021
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#90487 (Add a chapter on reading Rustdoc output) - rust-lang#90508 (Apply adjustments for field expression even if inaccessible) - rust-lang#90627 (Suggest dereference of `Box` when inner type is expected) - rust-lang#90642 (use matches!() macro in more places) - rust-lang#90646 (type error go brrrrrrrr) - rust-lang#90649 (Run reveal_all on MIR when inlining is activated.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Dec 5, 2021
Enable rustbot shortcuts for rust-clippy This enables shortcuts for ``@rustbot`.` Just a quality of life feature for contributors. |Shortcut| Full comment | |---|---| | ``@rustbot` ready` | ``@rustbot` label -S-waiting-on-author +S-waiting-on-review` | | ``@rustbot` author` | ``@rustbot` label +S-waiting-on-author -S-waiting-on-review` | See: https://github.com/rust-lang/triagebot/wiki/Shortcuts The documentation also states that the author/assignee will be pinged. However, this doesn't seem to be the case, it at least hasn't done so for me and in this [PR](rust-lang/rust#90642 (comment)) --- changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.