Assoc item cleanup

[matthewjasper]

This removes some fields from ObligationCauseCode

Split out of #90639

[rust-highfive]

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

[cjgillot]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 37f8b7dfccd88f38abd91013092fbc8b1c7dea3e with merge 5378c9f4bd027bfc59e71c557bc0e3eeb8db49a7...

[cjgillot]

Sorry for the ping oli-obk, I mis-clicked.

[bors]

☀️ Try build successful - checks-actions
Build commit: 5378c9f4bd027bfc59e71c557bc0e3eeb8db49a7 (5378c9f4bd027bfc59e71c557bc0e3eeb8db49a7)

[rust-timer]

Queued 5378c9f4bd027bfc59e71c557bc0e3eeb8db49a7 with parent 3cd3bbe, future comparison URL.

[rust-timer]

Finished benchmarking commit (5378c9f4bd027bfc59e71c557bc0e3eeb8db49a7): comparison url.

Summary: This change led to large relevant mixed results 🤷 in compiler performance.

• Small improvement in instruction counts (up to -0.8% on incr-full builds of ctfe-stress-4)
• Large regression in instruction counts (up to 2.3% on full builds of keccak)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

[matthewjasper]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit f7989bda6cb1efb9705f429990c740d245c162f0 with merge 15c0e0e6a71c795b8ee72fdd01b9fcd2ad894be3...

[bors]

☀️ Try build successful - checks-actions
Build commit: 15c0e0e6a71c795b8ee72fdd01b9fcd2ad894be3 (15c0e0e6a71c795b8ee72fdd01b9fcd2ad894be3)

[rust-timer]

Queued 15c0e0e6a71c795b8ee72fdd01b9fcd2ad894be3 with parent 3326f19, future comparison URL.

[rust-timer]

Finished benchmarking commit (15c0e0e6a71c795b8ee72fdd01b9fcd2ad894be3): comparison url.

Summary: This change led to large relevant mixed results 🤷 in compiler performance.

• Small improvement in instruction counts (up to -0.8% on full builds of ctfe-stress-4)
• Large regression in instruction counts (up to 2.3% on full builds of keccak)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

[matthewjasper]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

☀️ Try build successful - checks-actions
Build commit: c12bd3a2dfbe2dbf507f94d78372a7bf87be2930 (c12bd3a2dfbe2dbf507f94d78372a7bf87be2930)

[rust-timer]

Queued c12bd3a2dfbe2dbf507f94d78372a7bf87be2930 with parent 0727994, future comparison URL.

[rust-timer]

Finished benchmarking commit (c12bd3a2dfbe2dbf507f94d78372a7bf87be2930): comparison url.

Summary: This change led to large relevant regressions 😿 in compiler performance.

• Large regression in instruction counts (up to 2.3% on full builds of keccak)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

[matthewjasper]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 9734c03 with merge 73a04f9e6b6dda76aca299429e4784b13e6685d3...

[bors]

☀️ Try build successful - checks-actions
Build commit: 73a04f9e6b6dda76aca299429e4784b13e6685d3 (73a04f9e6b6dda76aca299429e4784b13e6685d3)

[rust-timer]

Queued 73a04f9e6b6dda76aca299429e4784b13e6685d3 with parent 90a273b, future comparison URL.

[rust-timer]

Finished benchmarking commit (73a04f9e6b6dda76aca299429e4784b13e6685d3): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

[cjgillot]

r=me with the PR message updated.

[matthewjasper]

I was hoping to readd some changes back into this PR, but I guess this can be merged as is for now.
@bors r=cjgillot

[bors]

📌 Commit 9734c03 has been approved by cjgillot

[bors]

⌛ Testing commit 9734c03 with merge 3d29b68...

[bors]

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 3d29b68 to master...

[rust-timer]

Finished benchmarking commit (3d29b68): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression