ast: Fix naming conventions in AST structures #90671
Conversation
TraitKind -> Trait TyAliasKind -> TyAlias ImplKind -> Impl FnKind -> Fn All `*Kind`s in AST are supposed to be enums. Tuple structs are converted to braced structs for the types above, and fields are reordered in syntactic order. Also, mutable AST visitor now correctly visit spans in defaultness, unsafety, impl polarity and constness.
|
Some changes occurred in src/tools/rustfmt. Some changes occurred in src/tools/clippy. cc @rust-lang/clippy |
|
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r=me with CI green |
|
I was planning on doing a subtree sync when I saw this. I've recently done a decent amount of refactoring of the impacted code on the rustfmt side which is likely to cause some hefty merge conflicts. Would be good to give bors a high priority on this one to get it landed more quickly since dealing with merge conflicts during subtree syncs is a bit of a pain |
|
📌 Commit 2834f57 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (68568dc): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
TraitKind -> Trait
TyAliasKind -> TyAlias
ImplKind -> Impl
FnKind -> Fn
All
*Kinds in AST are supposed to be enums.Tuple structs are converted to braced structs for the types above, and fields are reordered in syntactic order.
Also, mutable AST visitor now correctly visit spans in defaultness, unsafety, impl polarity and constness.
Noticed when reviewing #90076.