Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only shown relevant type params in E0283 label #90709

Merged
merged 4 commits into from
Dec 8, 2021
Merged

Only shown relevant type params in E0283 label #90709

merged 4 commits into from
Dec 8, 2021

Commits on Dec 7, 2021

  1. Only shown relevant type params in E0283 label 

    When we point at a binding to suggest giving it a type, erase all the
type for ADTs that have been resolved, leaving only the ones that could
not be inferred. For small shallow types this is not a problem, but for
big nested types with lots of params, this can otherwise cause a lot of
unnecessary visual output.
    @estebank
    estebank committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    78e88f4 View commit details
    Browse the repository at this point in the history

  2. Refer to uninferred const params by their name, instead of { _: _ } 

    When the value of a const param isn't inferred, replace it with the
param name from the definition.
    @estebank
    estebank committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    3fd15c8 View commit details
    Browse the repository at this point in the history

  3. Refer to const params as "const params" and not "type params"

    @estebank
    estebank committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    6a691b1 View commit details
    Browse the repository at this point in the history

  4. Add test with multiple type params failing inference

    @estebank
    estebank committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    7271d1f View commit details
    Browse the repository at this point in the history