-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 5 pull requests #90769
Rollup of 5 pull requests #90769
Conversation
…yn514 Use computed visibility in rustdoc This PR changes `librustdoc` to use computed visibility instead of syntactic visibility. It was initially part of rust-lang#88019, but was separated due to concerns that it might cause a regression somewhere we couldn't predict. r? `@jyn514` cc `@cjgillot` `@petrochenkov`
… r=workingjubilee Allow simd_bitmask to return byte arrays cc `@rust-lang/project-portable-simd` `@workingjubilee`
…less-search-index-data, r=notriddle,camelid Remove potential useless data for search index I uncovered this case when working on rust-lang#90726 to debug rust-lang#90385. Explanations: if we have a full generic, we check if it has generics then we do the following: * If it has only one generic, we remove one nested level in order to not keep the "parent" generic (since it has empty name, it's useless after all). * Otherwise we add it alongside its generics. However, I didn't handle the case where a generic had no generics. Meaning that we were adding items with empty names in the search index. So basically useless data in the search index. r? `@camelid`
Use AddAssign impl
…f, r=dtolnay Fix collections entry API documentation. I found some documentation that seems out of date.
@bors r+ rollup=never p=5 |
📌 Commit 5f24975 has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (82af160): comparison url. Summary: This change led to very large relevant mixed results 🤷 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression |
@Mark-Simulacrum could this be caused by #90361 ? |
Since the perf regressions are in full doc builds they are more likely caused by #88447. |
Successful merges:
Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup