Assoc item cleanup Part 2 #90827
Merged
Assoc item cleanup Part 2 #90827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
|
⌛ Trying commit ba518ff with merge 717bcdb0d82f4a18a9cff553838f6c6c28599f5b... |
|
☀️ Try build successful - checks-actions |
|
Queued 717bcdb0d82f4a18a9cff553838f6c6c28599f5b with parent e4c23da, future comparison URL. |
|
Finished benchmarking commit (717bcdb0d82f4a18a9cff553838f6c6c28599f5b): comparison url. Summary: This change led to moderate relevant regressions 😿 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never |
rustbot
added
perf-regression
|
Investigating locally, the change looks spurious. Looking at the history of these tests shows that a similar change happened when #89550 was merged and then later disappeared. |
|
Ok, let's go ahead. |
|
📌 Commit ba518ff has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit ba518ff with merge 776c5d7b9ade1b3ddc57906ae020317db109e806... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
@bors retry |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (b053550): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AssocItemfromRegionVariableOrigin::AutoRefassociated_item_def_idsquery instead of theassociated_itemsquery when possibleThe change to
ObligationCauseCodefrom #90639 is omitted because it caused a perf regression.r? @cjgillot