Try to normalize associated types before processing obligations #90887

jackh726 · 2021-11-13T23:48:47Z

Closes #90729

r? @nikomatsakis

jackh726 · 2021-11-13T23:49:00Z

@bors try @rust-timer queue

rust-timer · 2021-11-13T23:49:01Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2021-11-13T23:49:08Z

⌛ Trying commit 27a4ade1fdb09446b39e8f0cd7fd7544d1de7e26 with merge 3f8ac3c8c9bdbe3ad503f8356af71c9f3a5242df...

bors · 2021-11-14T01:24:51Z

☀️ Try build successful - checks-actions
Build commit: 3f8ac3c8c9bdbe3ad503f8356af71c9f3a5242df (3f8ac3c8c9bdbe3ad503f8356af71c9f3a5242df)

rust-timer · 2021-11-14T01:24:52Z

Queued 3f8ac3c8c9bdbe3ad503f8356af71c9f3a5242df with parent b416e38, future comparison URL.

rust-timer · 2021-11-14T05:21:20Z

Finished benchmarking commit (3f8ac3c8c9bdbe3ad503f8356af71c9f3a5242df): comparison url.

Summary: This change led to large relevant regressions 😿 in compiler performance.

Large regression in instruction counts (up to 2.8% on full builds of wg-grammar)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

nikomatsakis · 2021-11-18T18:31:51Z

@jackh726 I don't recall us talking about this PR, have I just forgotten? Did you ever look at the perf results?

jackh726 · 2021-11-18T18:58:25Z

@nikomatsakis I mentioned this at the end of our meeting on Monday.

As far as perf, I haven't done anything more than just looking through the benchmarks. It looks like wg-grammar was hit "hard" ~3%, whereas everything else is 1% or less. In theory, there might be an optimization that could be done (maybe first check if there are projection types in obligation.predicate?). But this does fix a number of things that I think, on balance, mean the perf hit is okay.

compiler/rustc_trait_selection/src/traits/fulfill.rs

nikomatsakis · 2022-02-07T14:26:54Z

@bors rollup=never

compiler/rustc_trait_selection/src/traits/fulfill.rs

jackh726 · 2022-02-07T18:37:46Z

@bors try @rust-timer queue

rust-timer · 2022-02-07T18:37:47Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-02-07T18:37:55Z

⌛ Trying commit c920e6605cf55518ef9a7100395849e4914a8c75 with merge 2b9a45228e828686978ed677f84e1df9c4146666...

rust-timer · 2022-03-08T04:46:21Z

Finished benchmarking commit (67b3e81): comparison url.

Summary: This benchmark run did not return any relevant results. 20 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Add a couple tests for rust-lang#90887 fixes closes rust-lang#56556 closes rust-lang#90875 These are confirmed fixes by rust-lang#90887, so r? `@jackh726`

Add a couple tests for rust-lang#90887 fixes closes rust-lang#56556 closes rust-lang#90875 These are confirmed fixes by rust-lang#90887, so r? ``@jackh726``

Rollup of 7 pull requests Successful merges: - rust-lang#96329 (Add a couple tests for rust-lang#90887 fixes) - rust-lang#97009 (Allow `unused_macro_rules` in path tests) - rust-lang#97075 (Add regression test for rust-lang#81804) - rust-lang#97079 (Change `Successors` to `impl Iterator<Item = BasicBlock>`) - rust-lang#97080 (remove the `RelateResultCompare` trait) - rust-lang#97093 (Migrate `maybe_recover_from_bad_type_plus` diagnostic) - rust-lang#97102 (Update function pointer call error message) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

…<try> never normalize without eager inference replacement unsure why we previously didn't do so, wasn't able to find an explanation in rust-lang#90887. This adds some complexity to the trait system and is afaict unnecessary, r? types cc `@jackh726`

…<try> some trait system cleanups Always eagerly replace projections with infer vars if normalization is ambig. Unsure why we previously didn't do so, wasn't able to find an explanation in rust-lang#90887. This adds some complexity to the trait system and is afaict unnecessary. The second commit simplifies `pred_known_to_hold_modulo_regions`, afaict the optional `fulfill` isn't necessary anymore. r? types cc `@jackh726`

…jackh726,compiler-errors some trait system cleanups Always eagerly replace projections with infer vars if normalization is ambig. Unsure why we previously didn't do so, wasn't able to find an explanation in rust-lang#90887. This adds some complexity to the trait system and is afaict unnecessary. The second commit simplifies `pred_known_to_hold_modulo_regions`, afaict the optional `fulfill` isn't necessary anymore. r? types cc `@jackh726`

…compiler-errors some trait system cleanups Always eagerly replace projections with infer vars if normalization is ambig. Unsure why we previously didn't do so, wasn't able to find an explanation in rust-lang#90887. This adds some complexity to the trait system and is afaict unnecessary. The second commit simplifies `pred_known_to_hold_modulo_regions`, afaict the optional `fulfill` isn't necessary anymore. r? types cc `@jackh726`

rust-highfive assigned nikomatsakis Nov 13, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 13, 2021

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 13, 2021

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Nov 14, 2021

apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 18, 2021

jackh726 mentioned this pull request Jan 10, 2022

Don't over-constrain projections in generic method signatures #92728

Closed

jackh726 force-pushed the issue-90729 branch 2 times, most recently from 136ac6a to bcdd97b Compare January 15, 2022 09:06

This comment has been minimized.

Sign in to view

jackh726 force-pushed the issue-90729 branch from bcdd97b to 4da6eb3 Compare January 15, 2022 23:31

jackh726 mentioned this pull request Jan 27, 2022

Normalize possibly un-normalized GAT projections #93361

Closed

nikomatsakis reviewed Feb 7, 2022

View reviewed changes

compiler/rustc_trait_selection/src/traits/fulfill.rs Outdated Show resolved Hide resolved

jackh726 commented Feb 7, 2022

View reviewed changes

compiler/rustc_trait_selection/src/traits/fulfill.rs Outdated Show resolved Hide resolved

jackh726 force-pushed the issue-90729 branch from 4da6eb3 to c920e66 Compare February 7, 2022 18:36

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 7, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 8, 2022

bors merged commit 67b3e81 into rust-lang:master Mar 8, 2022

rustbot added this to the 1.61.0 milestone Mar 8, 2022

jackh726 deleted the issue-90729 branch March 8, 2022 03:17

This was referenced Mar 8, 2022

Failed to unify types when using GATs and HRTBs #93341

Closed

Confusing output for signature mismatch in Fn trait with GAT lifetime parameter #93342

Closed

rustbot removed the perf-regression Performance regression. label Mar 8, 2022

Alexendoo mentioned this pull request Mar 9, 2022

min_specialization with default generic causes an ICE #79224

Closed

aliemjay mentioned this pull request Apr 23, 2022

Add a couple tests for #90887 fixes #96329

Merged

aliemjay mentioned this pull request Apr 23, 2022

Ordering of bounds matters with GAT/HRTB #96321

Open

aliemjay added a commit to aliemjay/rust that referenced this pull request Apr 23, 2022

Add a couple tests for rust-lang#90887 fixes

a0b464a

aliemjay mentioned this pull request May 6, 2022

GAT with HRTB yields weird inference errors. #96750

Open

Dylan-DPC mentioned this pull request May 17, 2022

Rollup of 5 pull requests #97107

Closed

JohnTitor mentioned this pull request May 17, 2022

Rollup of 7 pull requests #97111

Merged

compiler-errors mentioned this pull request Aug 2, 2022

Normalization can skip WF #100041

Open

laurmaedje mentioned this pull request Sep 14, 2022

Function type with HRTB and associated type argument unifies inconsistently #101794

Open

lcnr mentioned this pull request Jan 29, 2024

some trait system cleanups #120463

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Try to normalize associated types before processing obligations #90887

Try to normalize associated types before processing obligations #90887

jackh726 commented Nov 13, 2021

jackh726 commented Nov 13, 2021

rust-timer commented Nov 13, 2021

bors commented Nov 13, 2021

bors commented Nov 14, 2021

rust-timer commented Nov 14, 2021

rust-timer commented Nov 14, 2021

nikomatsakis commented Nov 18, 2021

jackh726 commented Nov 18, 2021

This comment has been minimized.

nikomatsakis commented Feb 7, 2022

jackh726 commented Feb 7, 2022

rust-timer commented Feb 7, 2022

bors commented Feb 7, 2022

rust-timer commented Mar 8, 2022

Try to normalize associated types before processing obligations #90887

Try to normalize associated types before processing obligations #90887

Conversation

jackh726 commented Nov 13, 2021

jackh726 commented Nov 13, 2021

rust-timer commented Nov 13, 2021

bors commented Nov 13, 2021

bors commented Nov 14, 2021

rust-timer commented Nov 14, 2021

rust-timer commented Nov 14, 2021

nikomatsakis commented Nov 18, 2021

jackh726 commented Nov 18, 2021

This comment has been minimized.

nikomatsakis commented Feb 7, 2022

jackh726 commented Feb 7, 2022

rust-timer commented Feb 7, 2022

bors commented Feb 7, 2022

rust-timer commented Mar 8, 2022