-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update llvm submodule #90954
Update llvm submodule #90954
Conversation
Amanieu
commented
Nov 16, 2021
- [DIArgList] Re-unique after changing operands to fix non-determinism
- [AArch64][GlobalISel] Fix an crash in RBS due to a new regclass being added.
r? @cuviper (rust-highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
📌 Commit 530cd5b has been approved by |
@bors rollup=never |
⌛ Testing commit 530cd5b with merge 3d7a084065d0e2008d211cf3162abb05e3a3caa4... |
💔 Test failed - checks-actions |
The job Click to see the possible cause of the failure (guessed by this bot)
|
⌛ Testing commit 530cd5b with merge 04f7e7be52e9d3ee87cb0796d905bc58e2e36574... |
💥 Test timed out |
@bors retry |
This should be beta backported, right? |
☀️ Test successful - checks-actions |
Finished benchmarking commit (faea820): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
It probably should, along #90301 |
I've set the backport nomination, but please consider adding details for the compiler team's consideration. |
Backporting details: Due to the upgrade to LLVM 13.0, which is part of the 1.56.0 release, there has been a regression in which rustc create nondeterministic output: #90301 . The two commits that this PR backports fix this regression. Even though this might not warrant a point release 1.56.2, it does make sense to keep 1.57.0 from getting it. |
Wouldn't also make sense to add |
@spastorino yeah it would, especially considering that 1.56.0 is likely going to be the MSRV for many projects like 1.31.0 was, due to the edition. |
Just to be clear, only the first commit is related to non-determinism. The second one fixes a crash with inline assembly, so strictly speaking it doesn't need to be backported but it doesn't hurt either. |
Beta backport approved as per compiler team on Zulip Also stable backport approved as per @spastorino suggestion. @rustbot label +beta-accepted |
Good point about the other fix existing too. It's important to point out that this PR does not contain the only determinism fix for llvm, the commit "[RegAllocFast] Fix nondeterminism in debuginfo generation" is also important. I've seen that beta does not include that commit either, but it is included as parent of the commits that this pr updated llvm to. So care should be taken that the backports of this PR don't just apply the two commits this PR added, but also the prior ones. Just updating the submodule to the same commit that this PR updated should do it. This also adds a drive by fix "[WebAssembly] Fix fixBrTableIndex removing instruction without checking uses", which is okay I think. |
[beta] backports - Fix assertion failures in OwnedHandle with windows_subsystem. rust-lang#88798 - Ensure that pushing empty path works as before on verbatim paths rust-lang#89665 - Feature gate + make must_not_suspend allow-by-default rust-lang#89826 - Only use clone3 when needed for pidfd rust-lang#89930 - Fix documentation header sizes rust-lang#90186 - Fixes incorrect handling of ADT's drop requirements rust-lang#90218 - Fix ICE when forgetting to Box a parameter to a Self::func call rust-lang#90221 - Prevent duplicate caller bounds candidates by exposing default substs in Unevaluated rust-lang#90266 - Update odht crate to 0.3.1 (big-endian bugfix) rust-lang#90403 - rustdoc: Go back to loading all external crates unconditionally rust-lang#90489 - Split doc_cfg and doc_auto_cfg features rust-lang#90502 - Apply adjustments for field expression even if inaccessible rust-lang#90508 - Warn for variables that are no longer captured rust-lang#90597 - Properly register text_direction_codepoint_in_comment lint. rust-lang#90626 - CI: Use ubuntu image to download openssl, curl sources, cacert.pem for x86 dist builds rust-lang#90457 - Android is not GNU rust-lang#90834 - Update llvm submodule rust-lang#90954 Additionally, this bumps the stage 0 compiler from beta to stable 1.56.1. r? `@Mark-Simulacrum`